Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): partially adapt storage UI to queries #1577

Merged
merged 12 commits into from
Sep 5, 2024

Conversation

imobachgs
Copy link
Contributor

@imobachgs imobachgs commented Sep 5, 2024

Trello: https://trello.com/c/nV7mjrf9/

This is the first step towards adapting the storage code to use queries. As this part of the code is rather complex, we decided to move as many components as possible to TypeScript to have a kind of security net.

What is included

  • Add a set of types from from our OpenAPI docs (see fix(rust): revamp the OpenAPI specification #1564) in api/storage/types.
  • Add a set of storage UI types in types/storage. We should unify the types, but let's do it later.
  • Define a new api/storage module moving big chunks of the StorageClient code.
  • Define a set of queries under queries/storage.
  • Adapt the ProposalPage component to use queries. It retrieves a lot of information that injects to nested components.
  • Convert ProposalPage and InstallationDeviceField to TypeScript.

What is missing

  • As you may see, the front end is not building. That problems (and other subtle bugs) will be fixed as we adapt the rest of storage components to TypeScript. So a bunch of additional pull requests will follow.
  • Additionally, we are removing all those skeletons from the UI. We will use a unified mechanism.

@imobachgs imobachgs changed the title Storage queries feat(web): partially adapt storage UI to queries Sep 5, 2024
Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I guess this is just one of many incoming changes against the storage-typescript feature branch, please go ahead. It's looking good and, honestly, I prefer to make a more in depth review when the code is closer to a final state. Hope you don't mind.

web/src/api/storage.ts Outdated Show resolved Hide resolved
@imobachgs imobachgs merged commit 83621ad into storage-typescript Sep 5, 2024
0 of 2 checks passed
@imobachgs imobachgs deleted the storage-queries branch September 5, 2024 07:56
imobachgs added a commit that referenced this pull request Sep 5, 2024
#1578)

Continuation of #1577. It covers the conversion of the following
components/modules:

* `EncryptionField`
* `PartitionsField`
* `ProposalSettingsSection`
* `SnapshotsField`
* `VolumeDialog`
* `InvalidMaxSizeError`
* `VolumeFields`
* `VolumeLocationDialog`
* `VolumeLocationSelectorTable`
* `BootSelection`
* `utils`
imobachgs added a commit that referenced this pull request Sep 5, 2024
Follow-up of #1577. It adapts `BootSelection` and `SpacePolicySelection`
to use queries.
imobachgs added a commit that referenced this pull request Sep 6, 2024
…2) (#1583)

Continuation of #1577. It covers the conversion of the following
components/modules:

* `BootConfigField`
* `device-utils`
* `SpaceActionsTable`
* `DeviceSelectorTable`
* `EncryptionSettingsDialog`
* `ProposalActionDialog`
* `ProposalActionSummary`
* `StoragePage`
* `ProposalResultSection`
* `ProposalTransactionalInfo`
* `SpaceActionsTable`
imobachgs added a commit that referenced this pull request Sep 6, 2024
Merge the following pull requests into `master`:

* #1577 
* #1578 
* #1580
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants