-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web): partially adapt storage UI to queries #1577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imobachgs
changed the title
Storage queries
feat(web): partially adapt storage UI to queries
Sep 5, 2024
dgdavid
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I guess this is just one of many incoming changes against the storage-typescript
feature branch, please go ahead. It's looking good and, honestly, I prefer to make a more in depth review when the code is closer to a final state. Hope you don't mind.
imobachgs
added a commit
that referenced
this pull request
Sep 5, 2024
#1578) Continuation of #1577. It covers the conversion of the following components/modules: * `EncryptionField` * `PartitionsField` * `ProposalSettingsSection` * `SnapshotsField` * `VolumeDialog` * `InvalidMaxSizeError` * `VolumeFields` * `VolumeLocationDialog` * `VolumeLocationSelectorTable` * `BootSelection` * `utils`
imobachgs
added a commit
that referenced
this pull request
Sep 5, 2024
Follow-up of #1577. It adapts `BootSelection` and `SpacePolicySelection` to use queries.
This was referenced Sep 5, 2024
imobachgs
added a commit
that referenced
this pull request
Sep 6, 2024
…2) (#1583) Continuation of #1577. It covers the conversion of the following components/modules: * `BootConfigField` * `device-utils` * `SpaceActionsTable` * `DeviceSelectorTable` * `EncryptionSettingsDialog` * `ProposalActionDialog` * `ProposalActionSummary` * `StoragePage` * `ProposalResultSection` * `ProposalTransactionalInfo` * `SpaceActionsTable`
imobachgs
added a commit
that referenced
this pull request
Sep 6, 2024
Merged
imobachgs
added a commit
that referenced
this pull request
Sep 20, 2024
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello: https://trello.com/c/nV7mjrf9/
This is the first step towards adapting the storage code to use queries. As this part of the code is rather complex, we decided to move as many components as possible to TypeScript to have a kind of security net.
What is included
api/storage/types
.types/storage
. We should unify the types, but let's do it later.api/storage
module moving big chunks of theStorageClient
code.queries/storage
.ProposalPage
component to use queries. It retrieves a lot of information that injects to nested components.ProposalPage
andInstallationDeviceField
to TypeScript.What is missing