Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): implement get answer and delete question #1453

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

jreidinger
Copy link
Contributor

Problem

Currently there is no way how to get answer for asked question ( service do it invisible on dbus ) and also delete is not exposed ( same case that services do it hidden on dbus ).

Solution

Implement DELETE /questions/:id and GET /questions/:id/answer HTTP calls.

@jreidinger jreidinger marked this pull request as ready for review July 10, 2024 20:15
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments. Otherwise, it looks good to me.

rust/package/agama.changes Outdated Show resolved Hide resolved
rust/package/agama.changes Outdated Show resolved Hide resolved
rust/agama-server/src/questions/web.rs Outdated Show resolved Hide resolved
rust/agama-server/src/questions/web.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@imobachgs imobachgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jreidinger jreidinger merged commit b450375 into master Jul 11, 2024
2 checks passed
@jreidinger jreidinger deleted the ask_question_http branch July 11, 2024 10:38
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants