fix(web): avoid type definitions errors at build time #1465

dgdavid · 2024-07-12T15:51:22Z

Problem

After merging #1456, the build task is failing when running it for the production environment (NODE_ENV=production npm run build).

Solution

Fix these problems having in mind that most of the complaints will be solved in a better way when migrating components to TypeScript.

Testing

npm run server succeed.
npm run tests succeed.
NODE_ENV=production npm run build succeed.

They allows to avoid some type errors like `Property 'hot' does not exist on type 'NodeModule'` See https://stackoverflow.com/a/55318758

The whole Page component has to be improved with possible rewrite to .tsx, but let's avoid the typecheck error by now.

@ts-ignore

Either, adding a temporary type definition or using @ts-ignore by now.

By adding the missing `resize` property for actions in tests and by adapting the JSX of the component used for rendering its content.

Because there are places that does not require such a label. Anyway, core/CardField is a component that must be rewritten/replaced.

By giving the "color-100" default value.

@ts-ignore

But also adds some @ts-ignore because this page is being already refactored in the context of adding a "global state manager" and a log changes / conflicts are expected.

It is a component that must be refactored or replace. Let's not invest too much time fixing types there meanwhile.

The component is going to be refactored or replaced soon and the prop can be easily re-introduced if really needed.

Related to the fact that core/EmptyState#rest prop is not well defined. Of course, it should be properly fixed in the short term.

Since it is a kind of experimental wrapper component that must be finished and, ideally, ported to .tsx now that writing TypeScript code is possible in Agama.

Basically bypassing them. Such a client needs a refactor in which types thingy must be addressed.

Removing the noEmit compiler option from tsconfig file and altering the order of babel and ts loaders to make them work without errors. Most probably that configuration has room for improvements yet.

Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621

dgdavid added 22 commits July 12, 2024 15:32

fix(web): install Webpack types definitions

804aa4d

They allows to avoid some type errors like `Property 'hot' does not exist on type 'NodeModule'` See https://stackoverflow.com/a/55318758

fix(web): avoid complaint about navigateTo prop

100cf2f

The whole Page component has to be improved with possible rewrite to .tsx, but let's avoid the typecheck error by now.

fix(web): avoid types complaints in SpacePolicySelection

7a937cb

Either, adding a temporary type definition or using @ts-ignore by now.

fix(web): please TypeScript for ProposalResultSection

4bb07fd

By adding the missing `resize` property for actions in tests and by adapting the JSX of the component used for rendering its content.

fix(web): add missing properties in ProposalActionsSummary.test.jsx

74ae057

fix(web): add missing inputRefs for PasswordAndConfirmationInput

253554e

fix(web): add type definition for DeviceSelection state

4ca3d3f

fix(web): add type definition for BootSelection state

4525546

fix(web): make core/CardField#label optional

9cc6a10

Because there are places that does not require such a label. Anyway, core/CardField is a component that must be rewritten/replaced.

fix(web): make core/EmptyState#color prop optional

934a8ec

By giving the "color-100" default value.

fix(web): make core/EmptyState#children prop optional

a41fd29

fix(web): improve type definitions of NetworkPage

712f873

But also adds some @ts-ignore because this page is being already refactored in the context of adding a "global state manager" and a log changes / conflicts are expected.

fix(web): disable type checking for core/Section

bf52662

It is a component that must be refactored or replace. Let's not invest too much time fixing types there meanwhile.

fix(web): remove leftovers in core/Page

2908692

fix(web): temporary ignore a rest typecheck at core/EmptyState

91f44cf

fix(web) drop no longer used prop at core/Center

0648ee2

The component is going to be refactored or replaced soon and the prop can be easily re-introduced if really needed.

fix(web) avoid a type definition complaint at LoginPage

d536cef

Related to the fact that core/EmptyState#rest prop is not well defined. Of course, it should be properly fixed in the short term.

fix(web): disable typechecking for core/Drawer

2f463e4

Since it is a kind of experimental wrapper component that must be finished and, ideally, ported to .tsx now that writing TypeScript code is possible in Agama.

fix(web): drop leftover property in a network test

98d3183

fix(web): avoid typecheck errors in storage client

e6631c1

Basically bypassing them. Such a client needs a refactor in which types thingy must be addressed.

fix(web): fine-tuning Webpack and TypeScript config

22fbaef

Removing the noEmit compiler option from tsconfig file and altering the order of babel and ts loaders to make them work without errors. Most probably that configuration has room for improvements yet.

fix(web): ensure proper code format

2ed8491

dgdavid changed the title ~~fix(web): avoid types definitions errors at build time~~ fix(web): avoid type definitions errors at build time Jul 12, 2024

dgdavid marked this pull request as ready for review July 12, 2024 18:59

dgdavid requested a review from imobachgs July 12, 2024 19:00

imobachgs approved these changes Jul 12, 2024

View reviewed changes

imobachgs merged commit ef87055 into master Jul 12, 2024
2 checks passed

imobachgs deleted the fix-ts-errors branch July 12, 2024 19:11

imobachgs mentioned this pull request Sep 20, 2024

Update to release 10 #1622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(web): avoid type definitions errors at build time #1465

fix(web): avoid type definitions errors at build time #1465

dgdavid commented Jul 12, 2024 •

edited

Loading

fix(web): avoid type definitions errors at build time #1465

fix(web): avoid type definitions errors at build time #1465

Conversation

dgdavid commented Jul 12, 2024 • edited Loading

Problem

Solution

Testing

dgdavid commented Jul 12, 2024 •

edited

Loading