Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(web): use queries to track the installer status #1514

Merged
merged 11 commits into from
Aug 1, 2024

Conversation

imobachgs
Copy link
Contributor

Follow-up of #1439. The goal of this PR is to change installer status tracking to Tanstack Query. Additionally, it adjust the HTTP API a bit.

Notes

The WithStatus mixin should not be relevant anymore. However, the storage UI still uses it to detect when the proposal changes. We should use a dedicated event instead.

Copy link
Contributor

@dgdavid dgdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks really good, thanks!

web/src/App.jsx Show resolved Hide resolved
web/src/App.jsx Show resolved Hide resolved
web/src/components/core/Installation.jsx Outdated Show resolved Hide resolved
web/src/types/status.ts Outdated Show resolved Hide resolved
@imobachgs imobachgs merged commit 6965ccf into master Aug 1, 2024
3 checks passed
@imobachgs imobachgs deleted the progress-queries branch August 1, 2024 07:59
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants