Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): avoid accidetally adding NPM TGZ source files to OBS #1502

Merged
merged 2 commits into from
Jul 26, 2024

Conversation

lslezak
Copy link
Contributor

@lslezak lslezak commented Jul 25, 2024

Problem

  • Sometimes a TGZ file is accidentally added to the OBS package sources, see an example
  • I guess that the osc service for some reason does not delete all downloaded NPM packages and leaves them there
  • Then they are submitted with the usual package sources

Solution

  • To avoid this problem always delete all *.tgz files before submitting the package to OBS

@lslezak lslezak changed the title CI: avoid accidetally adding NPM TGZ source files to OBS fix(ci): avoid accidetally adding NPM TGZ source files to OBS Jul 25, 2024
# sometimes the "osc service" run does not cleanup properly all
# downloaded NPM package tarballs and they are accidentally added to the
# OBS package, so delete any TGZ files present
run: rm -f *.tgz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how it will look in ci output? will it print all deleted files? maybe adding rm -vf would help to see what is removed to verify if something unexpected happen.

@lslezak lslezak merged commit cb36d47 into master Jul 26, 2024
@lslezak lslezak deleted the ci_submission_fix branch July 26, 2024 07:48
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants