-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(web): use queries for dealing with questions #1516
Conversation
529c7bf
to
d2317f3
Compare
d2317f3
to
7c7b049
Compare
import GenericQuestion from "~/components/questions/GenericQuestion"; | ||
import QuestionWithPassword from "~/components/questions/QuestionWithPassword"; | ||
import LuksActivationQuestion from "~/components/questions/LuksActivationQuestion"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've agreed on not exporting all components in index file ( see https://trello.com/c/c0GEUMQ8 (internal link) and #1049). And this is a little step towards such an agreement. However, looking at it, two questions comes to my mind:
-
Should we use
~/components/<namespace>/<Component>
or./<Component>
. I see the first approach kind of safe and stable, since it does not matter from where you are importing the component. -
If we use ``~/components//
does make sense to keep exporting _public_ components in the index file. For example, for importing
Questions.tsx` we couldimport Questions from "~/components/questions/Questions";
or
import { Questions } from "~/components/questions";
Honestly, for namespaces exporting a single component there is not too much difference / advantages. Another story is when importing multiple components from a single namespace, like core. Similar to what happens when importing components from PatternFly: it would be really annoying if we have had to import each component from its path.
Just sharing thoughts. No strong opinion here (yet 😝)
import GenericQuestion from "~/components/questions/GenericQuestion"; | ||
import QuestionWithPassword from "~/components/questions/QuestionWithPassword"; | ||
import LuksActivationQuestion from "~/components/questions/LuksActivationQuestion"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This three import also reminds me the article I shared on slack channel two weeks ago about naming: https://kyleshevlin.com/prefer-noun-adjective-naming
It isn't exactly the same case than the article, but maybe going for QuestionGeneric
, QuestionWithPassword
, and QuestionLuksActivation
would make them more consistent from a naming POV. Again, no strong opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we could just drop the Question
prefix/suffix since they are already in the questions
namespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks almost good. Thanks!
Co-authored-by: Imobach González Sosa <[email protected]>
62052b8
to
459f06c
Compare
PUT instead of PATCH.
By using PF/Stack#hasGutter for adding vertical space between internal components.
Prepare for releasing Agama 10· * #1263 * #1330 * #1407 * #1408 * #1410 * #1411 * #1412 * #1416 * #1417 * #1419 * #1420 * #1421 * #1422 * #1423 * #1424 * #1425 * #1428 * #1429 * #1430 * #1431 * #1432 * #1433 * #1436 * #1437 * #1438 * #1439 * #1440 * #1441 * #1443 * #1444 * #1445 * #1449 * #1450 * #1451 * #1452 * #1453 * #1454 * #1455 * #1456 * #1457 * #1459 * #1460 * #1462 * #1464 * #1465 * #1466 * #1467 * #1468 * #1469 * #1470 * #1471 * #1472 * #1473 * #1475 * #1476 * #1477 * #1478 * #1479 * #1480 * #1481 * #1482 * #1483 * #1484 * #1485 * #1486 * #1487 * #1488 * #1489 * #1491 * #1492 * #1493 * #1494 * #1496 * #1497 * #1498 * #1499 * #1500 * #1501 * #1502 * #1503 * #1504 * #1505 * #1506 * #1507 * #1508 * #1510 * #1511 * #1512 * #1513 * #1514 * #1515 * #1516 * #1517 * #1518 * #1519 * #1520 * #1522 * #1523 * #1524 * #1525 * #1526 * #1527 * #1528 * #1529 * #1530 * #1531 * #1532 * #1533 * #1534 * #1535 * #1536 * #1537 * #1540 * #1541 * #1543 * #1544 * #1545 * #1546 * #1547 * #1548 * #1549 * #1550 * #1552 * #1553 * #1554 * #1555 * #1556 * #1557 * #1558 * #1559 * #1560 * #1562 * #1563 * #1565 * #1566 * #1567 * #1568 * #1569 * #1570 * #1571 * #1572 * #1573 * #1574 * #1575 * #1576 * #1577 * #1578 * #1579 * #1580 * #1581 * #1583 * #1584 * #1585 * #1586 * #1587 * #1588 * #1589 * #1590 * #1591 * #1592 * #1593 * #1596 * #1597 * #1598 * #1600 * #1602 * #1605 * #1606 * #1607 * #1608 * #1610 * #1611 * #1612 * #1613 * #1614 * #1619 * #1620 * #1621
In the context of #1439, replace Questions client by its equivalent using TanStack Query.
Additionally, it includes two commits with changes out of the scope of the PBI we're working on. Namely:
Tested manually with a LuksActivationQuestion
Related to https://trello.com/c/8u1WOJz4 (internal link)