Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): drop dead code at product client #1498

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

dgdavid
Copy link
Contributor

@dgdavid dgdavid commented Jul 24, 2024

Drop dead code that was replaced by its equivalent using TanStack Query. See #1454.

Which was replaced by its equivalent using Tanstack query. See
#1454.
@imobachgs imobachgs merged commit 4935eed into master Jul 25, 2024
2 checks passed
@imobachgs imobachgs deleted the drop-product-dead-code branch July 25, 2024 08:29
imobachgs added a commit that referenced this pull request Jul 25, 2024
At this moment, the code for working with product registration is not
used. Moreover, it has to be migrated to a TanStack Query approach
because reasons stated at #1439


Thus, we've agreed to drop it meanwhile in order to have less
dead/unused/pending to adapt code.

Please, note that changes were done on top of
#1498, reason why would be nice to
merge this after it. Additionally, it includes a removal of software
typedef comments that were forgotten at
#1483 and
#1496.
@imobachgs imobachgs mentioned this pull request Sep 20, 2024
imobachgs added a commit that referenced this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants