-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component System: Continue Integration #28399
Comments
I'm copying over some issues I raised while working on #28624::
I also opened #28661 that proposes the removal of the temporary feature flag that excludes G2 components codebase from the upcoming WordPress release. |
@gziolo +100 on concerns for testing. We need to go back to add tests for these component hooks 👍 (as well as new things coming into Gutenberg) |
Added several missing components from here that are dependencies of |
Alrighty! We have another batch of updates ready for merge (thanks a bunch @sarayourfriend !)
I think they should be merged in that order. According to the status site, we're currently at ~16% integrated. This is great! |
Removing the Good First Issue label because this is no longer a good first issue as demonstrated by @ramonjd and @ntsekouras's attempts to integrate some components. |
Closing this issue in favor of the bigger tracking issue at #30503 All the remaining components from this issue have been moved over to that tracking issue under the "Finish the FontSizePicker integration" heading |
This is an extension of Implementing a Component System
Context ✨
The
FontSizePicker
component was first to receive the upgrade to use the new Components System.We opted for a strategy (proposed by @gziolo) that imports and uses the various system parts via npm dependencies, rather than migrating the code by copying/pasting them over.
This was largely to expedite us figuring out the process for integration.
Using the new Component System code via external packages is not the end goal.
Back Filling 🔙
@gziolo has identified the component dependencies of
FontSizePicker
in a comment.We're in a place where we can work on "back filling" these components so that
FontSizePicker
would no longer depend on external component dependenciesComponents List 📦
Below is the list of components we'll need to integrate into
@wordpress/components
from the new component system library.These have been ranked in dependency order, as well as complexity:
MenuReplaced byItemGroup
BaseField
#32250)I've added this to the running G2 Components integration spreadsheet to help track the progress:
https://docs.google.com/spreadsheets/d/1gfzznyJtTr3hHoGkGRdeBRjhuZVMRalF9NuLrxkl4Nk/edit?usp=sharing
To get a visual sense of how these components are composed together, you can check out this visual flow map:
https://miro.com/app/board/o9J_khVkF9A=/?moveToWidget=3074457351837142359&cot=14
Contribution 🙏
Help in this effort is definitely welcome!
I recognize that there's a lot that goes into the new Component System.
I've recorded a walkthrough of it on the project blog:
https://g2components.wordpress.com/2020/12/02/walkthrough-integration-ideas/
If you're interested in helping and you're having trouble navigating the space, please let me know!
I'd be happy to help however I can.
I recorded a walkthrough tutorial on how we're moving these components (note: some of the things may be outdated. I'll need to re-record this, but it may help as a starting point)
https://g2components.wordpress.com/2021/01/27/moving-components-to-gutenberg-walkthrough/
The text was updated successfully, but these errors were encountered: