Components: Update Flex #28609
Merged
Components: Update Flex #28609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +1.3 kB (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/g2-flex
branch
from
fce18c8 to
2a5ad25
Compare
sarayourfriend
force-pushed
the
add/g2-flex
branch
from
2a5ad25 to
dd9e4a5
Compare
32 tasks
ItsJonQ
reviewed
Feb 3, 2021
ItsJonQ
reviewed
Feb 3, 2021
| * | ||
| * @example | ||
| * ```jsx | ||
| * import { Flex, FlexItem, FlexBlock, Text, View } from `@wordpress/components` |
There was a problem hiding this comment.
Minor update change the import path to components/ui.
It's a bummer that we have to manually duplicate this stuff in multiple places :(.
For now, I wonder if it may be easier remove the inline examples until we can figure out some tooling to help automate things
There was a problem hiding this comment.
Alternatively we could just remove the import statements from the inline examples. They're probably the least important part of the examples.
ItsJonQ
reviewed
Feb 3, 2021
|
@saramarcondes So far so good!! I'm testing this locally in Gutenberg, forcing the new I'm spotting a minor implementation issue.. but I think it can be easily resolved. To be specific, it's related to the current That being said.. I expect this to resolve by refactoring the In the meantime, we can add a patch fix to smoothen out P.S. Moving forward, it is unlikely for us to use |
|
Update: Alternatively... we could change the For context... Current implementation: G2 implementation: Technically they achieve the same thing. But I think the current implementation has less room for side-effects Update: Looked into things in the G2 repo. There's pros/cons to both Flex inner child gap strategies 😂 😭 . I think the newer G2 implementation offers more room for adjustments. I went through a bunch of places where this is used, in particular all For example, an input For a Not impossible, just a lot more work. With all this said... I think it's better to keep the G2 Flex gap strategy, and make retroactive adjustments to areas that may be affected. From what I've seen, it's only the |
ItsJonQ
approved these changes
Feb 3, 2021
3 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add G2 flex component
How has this been tested?
Storybook
Typecheck
Types of changes
New feature
Checklist: