Add type="button" by default to Button component #288
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Button>
component should havetype="button"
by default, or else it will default totype="submit"
when placing inside a<form>
element. It's also the default value in gutenberg's<Button>
component: https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/button/index.js#L77Alternatively, we can enforce explicit
type
attribute with tools like eslint.I ran into this problem when trying to place some components here inside a
<form>
element: WordPress/gutenberg#29755 (comment). IMHO, this should be handled in the design system rather in the app level.