Components: Add Divider #29433
Merged
Components: Add Divider #29433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
32 tasks
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
sarayourfriend
force-pushed
the
add/hooks-divider
branch
2 times, most recently
from
2763f7d to
9d43fd5
Compare
ItsJonQ
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
🚀 from me! Thank you @sarayourfriend . Excited to see TS being used for this 😍
|
@ItsJonQ What's say we wait to merge this until the snapshot tests are fixed from the update in |
sarayourfriend
force-pushed
the
add/hooks-divider
branch
from
2824c05 to
f3c014e
Compare
|
Yay! Thanks for following up on this @sarayourfriend . We should be able to merge once the tests are 🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new
Dividercomponent. Note that this removes the dependency onDropdown. Dropdown itself will have to targetDividerin its styles to render the dropdown styles ofDivider.How has this been tested?
Unit tests and storybook.
Note: Unit tests currently don't work due to style issues. Once the updates in #29230 to
toMatchStyleDiffSnapshotis merged these snapshots should be updated and fixed.Types of changes
New feature
Checklist: