Components: Add spinner #29146
Merged
Components: Add spinner #29146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
sarayourfriend
added
[Feature] Component System
|
Size Change: -57 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
@sarayourfriend Haiii! The component looks okay. Although, I'm not sure why the snapshot test has an entry that looks like this: |
|
Yeah that's what I was confused about. I need to do some fiddling around with this a little more to get this to a place we can merge it with those tests. |
|
@sarayourfriend Thank you! I checked the other places where we use snapshot diffing. The implementation looks correct 🤷 |
sarayourfriend
force-pushed
the
add/hooks-spinner
branch
from
b963917 to
b137d0d
Compare
|
@ItsJonQ fixed! Was missing the |
ItsJonQ
approved these changes
Feb 19, 2021
There was a problem hiding this comment.
🚀 from me @sarayourfriend !! I added some README + JSDoc examples really quickly :)
Edit: Ooo! I also made sure it was exported from the index.js file.
32 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new CSS-in-JS Spinner component.
Something is wrong with the snapshot tests, haven't figured it out yet, maybe @ItsJonQ can diagnose it.
How has this been tested?
Unit tests and storybook
Screenshots
Gravacao.de.Tela.2021-02-19.as.06.48.23.mov
Types of changes
New feature
Checklist: