Component System: Add basic tests for style system #29320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +981 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
gziolo
reviewed
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds some basic tests for
cssandstyledfrom the Style System for the new Components.At the moment, these functions come from an external library (
@wp-g2/styles) - so they serve a bit like integration tests to ensure that basic functionality is working correctly.This is to help improve test coverage for the new Component System as noted by @gziolo
#28399 (comment)
This update also bumps the
@wp-g2repos tov0.0.157.This includes the update for improved RTL rendering and
StyleQueryinterpolation:https://github.com/ItsJonQ/g2/releases/tag/v0.0.157
How has this been tested?
Tested locally in Jest
npm run test-unitChecklist: