Components: Add Popover #29084
Merged
Components: Add Popover #29084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: +499 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
32 tasks
Interesting :). Well, we can do some work to make the new Will take a look later today! <3 |
|
@sarayourfriend Haiii!
I guess that's the tricky part when components depend on another's context 🙈 If we wanted to make a "cleaner split", we can make @sarayourfriend What do you think? Re: Popover styles I took it for a spin, and it looked like it was working okay. There were some styles coming from the |
sarayourfriend
force-pushed
the
add/hooks-popover
branch
from
6005924 to
c31a492
Compare
sarayourfriend
changed the title
ItsJonQ
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
🚀 from me. Thanks @sarayourfriend !
Following up on our 🍐 session. Given how complex the correct Popover is, we think we should attempt to adapt it in a separate PR.
|
@sarayourfriend Haiii! I'm seeing a type (?) issue for
Not sure what's going on there 🤔 |
|
@ItsJonQ Have you |
|
@sarayourfriend I thought I did... I tried again, and it looks like it's okay now :). In other news... some of the E2E tests are failing with this error: I wonder what's up 🤔 |
|
@sarayourfriend I'm having trouble replicating this locally (my E2E tests are giving me other issues). For debugging purposes, I'm going to try out various versions of |
|
@sarayourfriend I have a hunch!! Checkout this line in https://github.com/ItsJonQ/g2/blob/main/packages/context/src/context-connect.js#L54 WrappedComponent[INTERPOLATION_CLASS_NAME] = `ic-${hash(displayName)}`;In However, in the case of Just a hunch! In browsing the local files that use |
|
Thanks for the fix @sarayourfriend !! I don't think this PR relies on this update anymore (although, it would be handy to have) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds Popover.
How has this been tested?
Unit tests and storybook
Types of changes
New features
Checklist: