Components: Add ControlGroup #28982
Merged
Components: Add ControlGroup #28982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
[Package] Components
sarayourfriend
requested review from
ajitbohra and
chrisvanpatten
as code owners
|
Size Change: 0 B Total Size: 1.38 MB ℹ️ View Unchanged
|
32 tasks
|
Thank you @sarayourfriend !! Taking a look at this now. |
ItsJonQ
approved these changes
Feb 16, 2021
There was a problem hiding this comment.
🚀 from me! Thanks @sarayourfriend
One small note... At the moment, the components coming in from @itsjonq/g2 won't know how to correctly render their borders + border radii.
This is because they're using different instances of the ControlGroupContext.
@itsjonq/g2 vs @wordpress/components/ui.
That's okay. This will auto-resolve once we move those components over.
For that, I'm 👍
I'm just writing this for context :)
|
@sarayourfriend Oh dear! I just noticed my update didn't push because you pushed one, haha. One moment |
…to add/control-group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
ControlGroupcomponent to group controls together 😀How has this been tested?
Storybook, unit tests pass
Screenshots
Types of changes
New feature
Checklist: