-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use hidden visibility when compiling externals #17231
Labels
component: build system
Bazel, CMake, dependencies, memory checkers, linters
priority: medium
type: feature request
Comments
jwnimmer-tri
added
the
component: build system
Bazel, CMake, dependencies, memory checkers, linters
label
May 19, 2022
This was referenced May 19, 2022
This was referenced May 27, 2022
This was referenced Sep 3, 2022
This was referenced Jan 18, 2023
This was referenced Jan 27, 2023
This was referenced Jul 31, 2023
We are getting really close here! |
This was referenced Aug 3, 2023
This was referenced Aug 26, 2023
Open
This was referenced Sep 23, 2023
This was referenced Oct 9, 2023
This was referenced Oct 26, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: build system
Bazel, CMake, dependencies, memory checkers, linters
priority: medium
type: feature request
When building private externals from source (i.e., anything other than #7451), we should use hidden symbol visibility, so that downstream users of Drake can use their own, different version of that code without any link-time or load-time conflicts.
For C code, we can use
-fvisibility=hidden
. For C++ code, can use//tools/workspace:vendor_cxx
if it compiles.Checklist:
Tricky, possibly unsolveable:
The overall plan for all externals lives in this spreadsheet.
Closing the loop:
Additional tasks:
tools/workspace
about the current policy, how to add a new external, etc.vendor_cxx.bzl
can offer any more sugar macro(s) to reduce boilerplate.The text was updated successfully, but these errors were encountered: