-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lcm] Eschew LCM C++ API (use C instead) #20116
Conversation
+@ggould-tri for feature review, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: 2 unresolved discussions, needs at least two assigned reviewers
-- commits
line 2 at r1:
nit: Mention the alternative, since most people don't know LCM's full API buffet.
Suggestion:
- 2500a1e: [lcm] Eschew LCM C++ API (use C API instead)
lcm/drake_lcm.cc
line 10 at r1 (raw file):
#include <glib.h> #include <lcm/lcm-cpp.hpp>
BTW: Took me a while to figure out why this was still here -- that styleguide prohibition on forward declaration really proves its point! :-)
C++ is just pointlessly slower, more complicated, and less ABI-stable.
2500a1e
to
7c7b062
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+@sammy-tri for platform review per schedule, please.
Reviewable status: LGTM missing from assignee sammy-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee sammy-tri(platform)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all discussions resolved, LGTM from assignees ggould-tri(platform),sammy-tri(platform)
After this commit, every bazel test I run in the manipulation repo that calls ApplyDefaultVisualization now fails with
|
For reference, a probably-relevant detail here is that Russ's repositories block all kernel This was supposed to be a behavior-neutral change, so I'm reverting in #20136 until I understand why it changed. |
Towards #17231.
See also #20115.
This change is