[lcm] Deprecate direct access to the native LCM library #20115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: newly deprecated
|
+@sammy-tri for feature review, please. |
It's not sufficiently ABI-stable to offer as Drake ABI.
jwnimmer-tri
force-pushed
the
lcm-deprecate-native-getter
branch
from
ea64774
to
5eb7363
Compare
sammy-tri
reviewed
Sep 5, 2023
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers
|
+@xuchenhan-tri for platform review per schedule, please (tomorrow). |
There was a problem hiding this comment.
Platform
Reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees sammy-tri(platform),xuchenhan-tri(platform)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not sufficiently ABI-stable to offer as Drake ABI, and because its LGPL we are required to expose its ABI if we use it.
This function is used nowhere in Drake or Anzu currently. (It was last used in Anzu in May, 2022.)
Towards #17231.
See also #20116.
This change is