-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Deprecate the ccd and fcl externals #18611
[workspace] Deprecate the ccd and fcl externals #18611
Conversation
+@rpoyner-tri for feature review, please. Note that the commits are curated and in Reviewable as r1 and r2. Reviewing them one-at-a-time might be easiest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers, when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)
+@sammy-tri for platform review, please. Note my comment above about reviewing commits one-at-a-time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)
04e6248
to
1dbf949
Compare
Towards #17231. In the near future, we can adjust the build recipes for
..._internal
to better suit our needs, but doing that here was too much churn. Here we just fork the rule largely unchanged, in support of deprecation.This change is