Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[workspace] Deprecate the ccd and fcl externals #18611

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

jwnimmer-tri
Copy link
Collaborator

@jwnimmer-tri jwnimmer-tri commented Jan 18, 2023

Towards #17231. In the near future, we can adjust the build recipes for ..._internal to better suit our needs, but doing that here was too much churn. Here we just fork the rule largely unchanged, in support of deprecation.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri added priority: low status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits release notes: newly deprecated This pull request contains new deprecations labels Jan 18, 2023
@jwnimmer-tri jwnimmer-tri marked this pull request as ready for review January 18, 2023 10:01
@jwnimmer-tri
Copy link
Collaborator Author

+@rpoyner-tri for feature review, please.

Note that the commits are curated and in Reviewable as r1 and r2. Reviewing them one-at-a-time might be easiest.

@jwnimmer-tri jwnimmer-tri changed the title Deprecate the ccd and fcl externals [workspace] Deprecate the ccd and fcl externals Jan 18, 2023
Copy link
Contributor

@rpoyner-tri rpoyner-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: needs at least two assigned reviewers, when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)

@jwnimmer-tri
Copy link
Collaborator Author

+@sammy-tri for platform review, please. Note my comment above about reviewing commits one-at-a-time.

Copy link
Contributor

@sammy-tri sammy-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 12 of 19 files at r1, 8 of 8 files at r2, all commit messages.
Reviewable status: when planning a "properly curated" merge commit the PR must always be rebased onto latest master (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit ba2dd13 into RobotLocomotion:master Jan 19, 2023
@jwnimmer-tri jwnimmer-tri deleted the fcl-internal branch January 19, 2023 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low release notes: newly deprecated This pull request contains new deprecations status: commits are properly curated https://drake.mit.edu/reviewable.html#curated-commits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants