[workspace] Deprecate the picosha2 external #19879
Conversation
Use vendored picosha2_internal instead (with an ODR-safe namespace). Install the LICENSE file.
jwnimmer-tri
added
release notes: newly deprecated
|
@drake-jenkins-bot linux-jammy-gcc-bazel-experimental-debug please |
|
+@rpoyner-tri for feature review, please. |
jwnimmer-tri
changed the title
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: needs at least two assigned reviewers
|
+@sherm1 for platform review per schedule, please. Note that some of what look-like new files are really just copies of existing files. |
There was a problem hiding this comment.
Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion
tools/workspace/picosha2/package.BUILD.bazel line 18 at r1 (raw file):
hdrs = ["picosha2.h"], includes = ["."], deprecation = "DRAKE DEPRECATED: The @picosha2 external is deprecated in Drake's WORKSPACE and will be removed on or after 2023-11-01.", # noqa
BTW should the deprecation message mention that picosha2 is still available?
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sherm1(platform)
tools/workspace/picosha2/package.BUILD.bazel line 18 at r1 (raw file):
Previously, sherm1 (Michael Sherman) wrote…
BTW should the deprecation message mention that picosha2 is still available?
In this case, the replacement is marked as "internal", so users are not supposed to use it.
When I copy-edit the release notes with all of these new deprecations, I'll add an overall instruction for how users can "fork" their own copy of any dependencies they actually still needed for their own purposes.
Use vendored
picosha2_internalinstead (with an ODR-safe namespace).Install the LICENSE file.
Towards #17231.
This change is