[workspace] Remove globbing from qhull build #17227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@EricCousineau-TRI for both reviews per schedule, please. @drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please |
|
Oops, debug builds are yelling. +(status: do not review) for now. |
Don't build unnecessary files: Coordinates.cpp, PointCoordinates.cpp, QhullPoints.cpp, QhullStat.cpp, RboxPoints.cpp, rboxlib_r.c. This makes our build and object code footprint smaller, and enables a future commit to use a better technique for C++ symbol visibility.
jwnimmer-tri
force-pushed
the
qhull-noglob
branch
from
da7bd8f
to
f3433e6
Compare
|
+@EricCousineau-TRI for both reviews per schedule, please. @drake-jenkins-bot mac-big-sur-clang-bazel-experimental-release please |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee EricCousineau-TRI(platform) (waiting on @jwnimmer-tri)
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
May 27, 2022
Don't build unnecessary files: Coordinates.cpp, PointCoordinates.cpp, QhullPoints.cpp, QhullStat.cpp, RboxPoints.cpp, rboxlib_r.c. This makes our build and object code footprint smaller, and enables a future commit to use a better technique for C++ symbol visibility.
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
Jun 1, 2022
Don't build unnecessary files: Coordinates.cpp, PointCoordinates.cpp, QhullPoints.cpp, QhullStat.cpp, RboxPoints.cpp, rboxlib_r.c. This makes our build and object code footprint smaller, and enables a future commit to use a better technique for C++ symbol visibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't build unnecessary files: Coordinates.cpp, PointCoordinates.cpp, QhullPoints.cpp, QhullStat.cpp, RboxPoints.cpp, rboxlib_r.c.
This makes our build and object code footprint smaller, and enables a future commit to use a better technique for C++ symbol visibility. Towards #17231.
This change is