[lcm] Use Impl in DrakeLcmLog #17290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This buries the upstream lcm header file into our cc file.
jwnimmer-tri
added
priority: low
status: single reviewer ok
|
+@sammy-tri for both reviews (as SME), please. |
sammy-tri
reviewed
May 31, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignee sammy-tri(platform) (waiting on @jwnimmer-tri)
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
Jun 1, 2022
This buries the upstream lcm header file into our cc file.
hongkai-dai
pushed a commit
to hongkai-dai/drake
that referenced
this pull request
Jun 6, 2022
This buries the upstream lcm header file into our cc file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This buries the upstream lcm header file into our cc file.
Towards #17231.
This change is