[workspace] Add reusable macro and documentation for vendor_cxx #17278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
added
priority: low
release notes: none
jwnimmer-tri
force-pushed
the
vendor-readability
branch
from
e4355d2
to
7b4444b
Compare
This was referenced May 27, 2022
|
+@rpoyner-tri for feature review, please. Low priority. |
Update yaml_cpp_internal to follow the new style.
jwnimmer-tri
force-pushed
the
vendor-readability
branch
from
7b4444b
to
d3f069b
Compare
rpoyner-tri
reviewed
May 31, 2022
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: LGTM missing from assignee rpoyner-tri(platform), needs at least two assigned reviewers (waiting on @jwnimmer-tri)
rpoyner-tri
reviewed
May 31, 2022
There was a problem hiding this comment.
Reviewable status: needs at least two assigned reviewers (waiting on @jwnimmer-tri)
|
+@sammy-tri for platform review per schedule, please. |
sammy-tri
reviewed
May 31, 2022
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, LGTM from assignees rpoyner-tri(platform),sammy-tri(platform) (waiting on @jwnimmer-tri)
aykut-tri
pushed a commit
to aykut-tri/drake
that referenced
this pull request
Jun 1, 2022
…tLocomotion#17278) Update yaml_cpp_internal to follow the new style.
hongkai-dai
pushed a commit
to hongkai-dai/drake
that referenced
this pull request
Jun 6, 2022
…tLocomotion#17278) Update yaml_cpp_internal to follow the new style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
@yaml_cpp_internalto follow the new style.For use in #17229 and #17230 and more afterwards. (Those serve as more examples of this macro.)
Towards #17231.
This change is