Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 6 RC1 #6117

Merged
merged 3 commits into from
Feb 11, 2019
Merged

Version 6 RC1 #6117

merged 3 commits into from
Feb 11, 2019

Conversation

danfinlay
Copy link
Contributor

@danfinlay danfinlay commented Feb 7, 2019 •
edited by whymarrh
Loading

  • #6082: Migrate all users to the new UI
  • #6114: Add setting for inputting gas price with a text field for advanced users.
  • #6091: Add Swap feature to CurrencyInput
  • #6090: Change gas labels to Slow/Average/Fast
  • #6112: Extract advanced gas input controls to their own component
  • #5929: Update design of phishing warning screen
  • #6120: Add class to sign footer button
  • #6116: Fix locale codes contains underscore never being preferred

whymarrh
whymarrh previously approved these changes Feb 7, 2019
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [7104cfc]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [17ddf62]: mascara, chrome, firefox, edge, opera

@metamaskbot
Copy link
Collaborator

Builds ready [028aaf3]: mascara, chrome, firefox, edge, opera

whymarrh
whymarrh suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmashuang pointed out a bug that we'll need to fix

tmashuang
tmashuang suggested changes Feb 7, 2019
View reviewed changes
Copy link
Contributor

@tmashuang tmashuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6118

@metamaskbot
Copy link
Collaborator

Builds ready [f6c9cde]: mascara, chrome, firefox, edge, opera

whymarrh
whymarrh previously approved these changes Feb 8, 2019
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [2147581]: mascara, chrome, firefox, edge, opera

tmashuang
tmashuang previously approved these changes Feb 11, 2019
View reviewed changes
@danfinlay danfinlay dismissed stale reviews from tmashuang and whymarrh via 86ff5f3 February 11, 2019 17:48
@danfinlay
Copy link
Contributor Author

Oh I'm sorry, I allowed a merge on my local branch, and it was just a changelog diff and now it broke the reviews. Rolling that back w/ a force push.

@metamaskbot
Copy link
Collaborator

Builds ready [2147581]: mascara, chrome, firefox, edge, opera

@danfinlay danfinlay merged commit 140fcb4 into develop Feb 11, 2019
@danfinlay danfinlay deleted the Version-6.0.0 branch February 11, 2019 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmashuang tmashuang tmashuang approved these changes

@whymarrh whymarrh whymarrh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danfinlay @metamaskbot @whymarrh @tmashuang