Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate all users to the new UI #6082

Merged
merged 5 commits into from
Feb 5, 2019

Conversation

whymarrh
Copy link
Contributor

This PR removes the old UI option from the app, migrates all users that were previously not using the new UI to the new UI, and displays an announcement for only those users.

Process

  1. We've dropped the betaUI feature flag here and add completedUiMigration state
  2. All users start with completedUiMigration set to true
  3. Any user that had the betaUI feature flag unset (i.e. false) has their completedUiMigration state set to false
  4. All users with completedUiMigration set to false have an simple announcement overlay displayed to them. The announcement overlay will be the first thing they see when they interact with MetaMask after it has updated (e.g. it will display over the unlock screen)

Announcement overlay

The announcement overlay displays the following:

Welcome to the new MetaMask UI. If you have feedback about the UI or feature requests, please reach out to our support team or on GitHub.

@whymarrh whymarrh requested review from danjm and tmashuang January 31, 2019 13:20
danjm
danjm previously approved these changes Jan 31, 2019
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I have not QA'd yet.

danjm
danjm previously approved these changes Feb 1, 2019
@danjm
Copy link
Contributor

danjm commented Feb 5, 2019

QA'd. Looks good to me.

@whymarrh whymarrh merged commit 697d5ad into MetaMask:develop Feb 5, 2019
@whymarrh whymarrh deleted the migrate-to-new-ui branch February 5, 2019 14:12
@danfinlay danfinlay mentioned this pull request Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants