Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix locale codes contains underscore will never be preferred. #6116

Merged

Conversation

me578022
Copy link
Contributor

@me578022 me578022 commented Feb 6, 2019

The locale codes contains underscore will never be preferred (e.g. zh_TW),
function should returns the original locale code but not converted.

@whymarrh whymarrh force-pushed the fix-get-first-preferred-lang-code-2 branch from 78c7023 to 7000446 Compare February 8, 2019 19:17
@whymarrh whymarrh force-pushed the fix-get-first-preferred-lang-code-2 branch from 7000446 to c45325a Compare February 8, 2019 19:24
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @me578022!

@whymarrh
Copy link
Contributor

whymarrh commented Feb 8, 2019

I rebased thin on develop which had the correct lockfile and squashed the commits. Thanks again!

@whymarrh whymarrh merged commit 1a4203a into MetaMask:develop Feb 8, 2019
@me578022 me578022 deleted the fix-get-first-preferred-lang-code-2 branch February 8, 2019 19:52
@danfinlay danfinlay mentioned this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants