Update design of phishing warning screen #5929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danfinlay this touches some of the wording changes you've recently made, let me know your thoughts on this as well |
danjm
previously approved these changes
Dec 13, 2018
tmashuang
previously approved these changes
Dec 13, 2018
|
I'm going to revert the wording on this PR back to the previous one. We should revisit the wording separately. |
whymarrh
force-pushed
the
phishing-redesign
branch
from
a630d17 to
7e13a26
Compare
whymarrh
force-pushed
the
phishing-redesign
branch
from
7e13a26 to
59a5f55
Compare
|
I've updated the wording here/reverted the wording changes here—this PR now contains no wording changes. This is good for another round of review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the design for the phishing warning screen as per @cjeria's comment on #2784.
The implementation is contains intentional subtle differences from the design as I've tried to reuse existing icons, images, and font styles. I've also kept all of the words from the original text (e.g. #5848, #5864, and #5875).
Old vs. new warning screens: