Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that custom gas data in state gets set from inline advance gas… #6114

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Ensure that custom gas data in state gets set from inline advance gas… #6114

merged 1 commit into from
Feb 6, 2019

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 6, 2019

… controls on send screen.

This PR fixes a bug that could be seen by doing the following:

  • toggle Advanced Gas Controls to true
  • edit the gas limit directly on the send screen
  • go to the confirm screen
  • notice that gas limit is what you just set on the send screen (this is correct behaviour)
  • click 'edit' and then the advanced tab
  • the gas limit will be 21000

After this PR, the gas limit on the last step will be the expected value, what was set on the send screen.

@danjm danjm requested a review from whymarrh as a code owner February 6, 2019 16:55
@metamaskbot
Copy link
Collaborator

Builds ready [5ada835]: mascara, chrome, firefox, edge, opera

whymarrh
whymarrh approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@whymarrh whymarrh merged commit 97e92a1 into develop Feb 6, 2019
@whymarrh whymarrh deleted the advanced-modal-confirm-from-send-bug branch February 6, 2019 17:13
@danfinlay danfinlay mentioned this pull request Feb 7, 2019
Merged
@tmashuang tmashuang restored the advanced-modal-confirm-from-send-bug branch February 7, 2019 21:50
@whymarrh whymarrh mentioned this pull request Feb 8, 2019
Merged
@danjm danjm deleted the advanced-modal-confirm-from-send-bug branch March 26, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whymarrh whymarrh whymarrh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danjm @metamaskbot @whymarrh