Fix advanced inline gas editing #6122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depending on what the status of the e2e tests are when you read this, I might still be working on 'em |
whymarrh
force-pushed
the
fix-gas-editing
branch
4 times, most recently
from
9e8573c to
72c8ae0
Compare
danjm
previously approved these changes
Feb 8, 2019
whymarrh
force-pushed
the
fix-gas-editing
branch
from
4aa2b00 to
0972e23
Compare
danjm
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6118
This PR fixes the ability to use both the non-advanced and advanced gas editing from the send and confirm screens. We were previously mixing hex and decimals numbers/overloading the dispatch functions for setting the gas data (#6112, #6114) and this PR moves the decimal/hex conversions into the container for the advanced controls where it's needed and uses the existing functions for dispatches which all expect gas in hex.
(This PR includes #6121 because that fixes the build, and I'm all about that green build. I can rebase this PR once that's merged.)