Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Send Transaction when selecting Tx Fee rates in MetaMask on v6 #6118

Closed
tmashuang opened this issue Feb 7, 2019 · 4 comments · Fixed by #6122
Closed

Unable to Send Transaction when selecting Tx Fee rates in MetaMask on v6 #6118

tmashuang opened this issue Feb 7, 2019 · 4 comments · Fixed by #6122
Assignees

Comments

@tmashuang
Copy link
Contributor

tmashuang commented Feb 7, 2019

Repro Steps:

  1. Be on any network with 2 created accounts with a balance
  2. Send Button
  3. Set Recipient Address to Account 2
  4. Set Amount to 1 ETH (or any amount that is sufficient)
  5. Set Slow or Fast Transaction Fee.
  6. Insufficient Funds error on Amount.

Additional Context

In my send state, I believe it shows the correct amounts for gasPrice/Amount, but when I select Advanced Options it shows me 1000000000 GWEI.

Edit: No, the gas price is definitely not correct conversion to 1000000000 GWEI. Seems like we changed how to converted the Slow/Fast Tx Fee tabs to number, or vise versa.

@tmashuang tmashuang changed the title Unable to Send Transaction in MetaMask on v6 Unable to Send Transaction when selecting Tx Fee rates in MetaMask on v6 Feb 7, 2019
@bdresser
Copy link
Contributor

bdresser commented Feb 7, 2019

@tmashuang perhaps from #6090 ?

@tmashuang
Copy link
Contributor Author

We're adding a couple extra zeros here

setGasPrice: (newPrice, gasLimit) => {
newPrice = decGWEIToHexWEI(newPrice)
dispatch(setGasPrice(newPrice))
dispatch(setCustomGasPrice(addHexPrefix(newPrice)))
dispatch(setGasTotal(calcGasTotal(gasLimit, newPrice)))
},

@tmashuang
Copy link
Contributor Author

tmashuang commented Feb 7, 2019

Can't revert, since it also is messing up number input for the 'Advanced Gas Controls'. Possible need to two convert the Slow/Fast tabs to just numbers.

@whymarrh
Copy link
Contributor

whymarrh commented Feb 8, 2019

I can confirm that this isn't because of #6090 or #6091

@whymarrh whymarrh self-assigned this Feb 8, 2019
@ghost ghost added the in progress label Feb 8, 2019
@ghost ghost removed the in progress label Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants