-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Swap feature to CurrencyInput #6091
Conversation
chikeichan
commented
Feb 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit test and lint fixes needed
Code looks good otherwise
that was fast @chikeichan ! @danfinlay @cjeria were you imagining the value would stay the same and the denomination would swap (as in the GIF) or that the values would swap along with the denomination? I can see arguments for either way, just want to check ~ |
The currency converter app I use keeps the denomination the same when swapping, so I'd go with how @chikeichan implemented it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM