Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swap feature to CurrencyInput #6091

Merged
merged 3 commits into from
Feb 6, 2019
Merged

Conversation

chikeichan
Copy link
Contributor

swap

Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test and lint fixes needed

Code looks good otherwise

@bdresser
Copy link
Contributor

bdresser commented Feb 1, 2019

that was fast @chikeichan !

@danfinlay @cjeria were you imagining the value would stay the same and the denomination would swap (as in the GIF) or that the values would swap along with the denomination? I can see arguments for either way, just want to check ~

@cjeria
Copy link
Contributor

cjeria commented Feb 4, 2019

The currency converter app I use keeps the denomination the same when swapping, so I'd go with how @chikeichan implemented it.

Copy link
Contributor

@whymarrh whymarrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants