Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTs: Ensure proper icons are used in transaction feed #17362

Closed
darkwing opened this issue Jan 23, 2023 · 0 comments · Fixed by #17440
Closed

NFTs: Ensure proper icons are used in transaction feed #17362

darkwing opened this issue Jan 23, 2023 · 0 comments · Fixed by #17440
Assignees
@darkwing
Labels
area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug

Comments

@darkwing
Copy link
Contributor

Describe the bug

It appears we may be using outdated icons in the transaction feed. After #17089 is merged, we should update icons as needed:

https://www.figma.com/file/8Xe22jEPgcElS5tWPw8AGM?node-id=772%3A9832&fuid=893620844198331628#351761302

Steps to reproduce

N/A

Error messages or log output

No response

Version

10.23

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response
@darkwing darkwing added type-bug area-NFTs team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jan 23, 2023
@darkwing darkwing self-assigned this Jan 26, 2023
darkwing added a commit that referenced this issue Jan 26, 2023
@darkwing
Fix #17362 - Ensure NFT icons are correct
6139cea
@darkwing darkwing mentioned this issue Jan 26, 2023
Merged
8 tasks
darkwing added a commit that referenced this issue Jan 27, 2023
@darkwing
Fix #17362 - Ensure NFT icons are correct (#17440)
6ee2d07 
* Fix #17362 - Ensure NFT icons are correct

* Update trash icon
409H added a commit to 409H/metamask-extension that referenced this issue Jan 27, 2023
@409H
Merge remote-tracking branch 'origin/develop' into feature/toggle-eth…
26c7253 
…sign

* origin/develop: (142 commits)
  Use network provider state, instead of CurrencyRateController state, to select 'nativeCurrency' (MetaMask#17450)
  [e2e]Add e2e test for deleting custom network (MetaMask#17254)
  Fix MetaMask#17362 - Ensure NFT icons are correct (MetaMask#17440)
  Fix MetaMask#17385 - Provide autohide callback for ActionMessage (MetaMask#17392)
  button link housekeeping (MetaMask#16885)
  Bump lavapack version to 5 (MetaMask#17431)
  feature: convert shared/modules/contract-utils.test.js to typescript (MetaMask#17435)
  Refactor confirm page container component from class to functional component (MetaMask#16907)
  Test parameter change cache miss (MetaMask#17346)
  Document callback-style background calls as deprecated (MetaMask#17376)
  Improving getMemoizedMetadataContractName selector (MetaMask#17432)
  [GridPlus] Bumps `gridplus-sdk` to v2.4.1 (MetaMask#16847)
  Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag (MetaMask#17354)
  Consolidated all component import paths (MetaMask#17368)
  updated new links for the stories (MetaMask#17369)
  Fix MetaMask#17388 - Remove dismiss button from NFT notification (MetaMask#17389)
  Remove a notification for falling back from STX to regular swaps (MetaMask#17374)
  Feat/15086/add banner severities component (MetaMask#17307)
  fix icon names (MetaMask#17391)
  Fix Playwright install step (MetaMask#17415)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkwing darkwing

Labels
area-NFTs team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #17362 - Ensure NFT icons are correct MetaMask/metamask-extension
1 participant
@darkwing