Remove a notification for falling back from STX to regular swaps #17374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
reviewed
Jan 24, 2023
Comment on lines
-377
to
-378
| const isStxNotEnoughFundsError = | ||
| currentSmartTransactionsError === stxErrorTypes.NOT_ENOUGH_FUNDS; |
There was a problem hiding this comment.
is this not an error we want to maintain?
There was a problem hiding this comment.
That's correct, we will fallback automatically to a regular swap if there is not enough funds for a gas fee via STX.
darkwing
approved these changes
Jan 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
The notification below for falling back from STX to regular swaps wasn't really actionable, caused a bit of confusion and unnecessary overhead. All that to communicate an edge case that most users will not encounter. We are removing it to simplify user experience.
Screenshots/Screencaps
Removed notification:
