Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated all component import paths #17368

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Conversation

NidhiKJha
Copy link
Member

This PR is to make import paths for components consistent and are imported from '../../component-library' in component-library documentation.

Fixes #16900

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

+ If there are functional changes:

  • Manual testing complete & passed
  • "Extension QA Board" label has been applied

@NidhiKJha NidhiKJha requested a review from a team as a code owner January 24, 2023 08:36
@NidhiKJha NidhiKJha added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Jan 24, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [f99d86e]
Page Load Metrics (1335 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94151114157
domContentLoaded101817541312220106
load104517541335208100
domInteractive101817541312220106
Bundle size diffs
  • background: 0 bytes
  • ui: -12 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17368 (f99d86e) into develop (cf10b2a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #17368      +/-   ##
===========================================
- Coverage    60.07%   60.06%   -0.01%     
===========================================
  Files          936      936              
  Lines        36049    36049              
  Branches      9261     9261              
===========================================
- Hits         21654    21651       -3     
- Misses       14395    14398       +3     
Impacted Files Coverage Δ
ui/pages/settings/info-tab/info-tab.component.js 4.17% <ø> (ø)
app/scripts/metamask-controller.js 60.49% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@garrettbear garrettbear merged commit 1d1b751 into develop Jan 25, 2023
@garrettbear garrettbear deleted the fix-16900-imports branch January 25, 2023 19:54
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate all component import paths
5 participants