Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Playwright install step #17415

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix Playwright install step #17415

merged 1 commit into from
Jan 25, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 25, 2023

The Playwright install step run in the test-storybook job has been updated to ensure that we are running the correct install command. Previously we were using yarn dlx, which would use the latest version of Playwright rather than the one currently installed. Instead now we are using yarn exec, which will invoke the playwright binary from the locally installed package. This binary has an install command that completes the necessary setup, which is to install custom patched browsers for Playwright to run.

Manual Testing Steps

This is meant to fix a CI failure, so CI should be sufficient to show that this is working.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

The Playwright install step run in the `test-storybook` job has been
updated to ensure that we are running the correct install command.
Previously we were using `yarn dlx`, which would use the latest version
of `Playwright` rather than the one currently installed. Instead now we
are using `yarn exec`, which will invoke the `playwright` binary from
the locally installed package. This binary has an `install` command
that completes the necessary setup, which is to install custom patched
browsers for Playwright to run.
@Gudahtt Gudahtt marked this pull request as ready for review January 25, 2023 17:30
@Gudahtt Gudahtt requested review from a team and kumavis as code owners January 25, 2023 17:30
@metamaskbot
Copy link
Collaborator

Builds ready [473a612]
Page Load Metrics (1447 ± 120 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint120172145178
domContentLoaded108018061410242116
load113518921447250120
domInteractive108018061410242116
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17415 (473a612) into develop (3d87f65) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff            @@
##           develop   #17415   +/-   ##
========================================
  Coverage    59.80%   59.80%           
========================================
  Files          936      936           
  Lines        35797    35797           
  Branches      9228     9228           
========================================
  Hits         21406    21406           
  Misses       14391    14391           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Gudahtt Gudahtt merged commit d2331c0 into develop Jan 25, 2023
@Gudahtt Gudahtt deleted the fix-playwright-install-step branch January 25, 2023 17:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants