Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #17385 - Provide autohide callback for ActionMessage #17392

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

When the autohide timer goes off, we should record the event so state updates and the ActionableMessage doesn't display again.

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner January 24, 2023 19:23
@darkwing darkwing requested a review from chloeYue January 24, 2023 19:23
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [76e8306]
Page Load Metrics (1487 ± 157 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1032151353014
domContentLoaded101921291459326157
load105321291487327157
domInteractive101921291459326157
Bundle size diffs
  • background: 0 bytes
  • ui: 69 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

Codecov Report

Merging #17392 (76e8306) into develop (0bf6aeb) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop   #17392      +/-   ##
===========================================
+ Coverage    59.93%   59.94%   +0.01%     
===========================================
  Files          936      936              
  Lines        36021    36022       +1     
  Branches      9269     9269              
===========================================
+ Hits         21587    21590       +3     
+ Misses       14434    14432       -2     
Impacted Files Coverage Δ
...onents/ui/actionable-message/actionable-message.js 82.22% <0.00%> (-1.87%) ⬇️
ui/pages/home/home.component.js 0.00% <0.00%> (ø)
app/scripts/metamask-controller.js 60.75% <0.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

vthomas13
vthomas13 previously approved these changes Jan 25, 2023
Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

brad-decker
brad-decker previously approved these changes Jan 25, 2023
@NidhiKJha
Copy link
Member

@darkwing should we add autoHide for removeCollectibleMessage as well?

@darkwing darkwing dismissed stale reviews from brad-decker and vthomas13 via d74e51e January 25, 2023 19:33
@darkwing
Copy link
Contributor Author

Good shout @NidhiKJha ! Updated!

@darkwing darkwing force-pushed the 17385-autohide-callback branch from d74e51e to 48c3721 Compare January 25, 2023 20:05
@metamaskbot
Copy link
Collaborator

Builds ready [48c3721]
Page Load Metrics (1612 ± 545 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint943160392797383
domContentLoaded999530315871120538
load999540816121134545
domInteractive999530315871120538
Bundle size diffs
  • background: 0 bytes
  • ui: 101 bytes
  • common: 0 bytes

Copy link
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA test OK, LGTM

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@darkwing darkwing merged commit b21e0df into develop Jan 27, 2023
@darkwing darkwing deleted the 17385-autohide-callback branch January 27, 2023 14:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NFTs: The disappearing toast reappears when you navigate away and then back
7 participants