-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17385 - Provide autohide callback for ActionMessage #17392
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [76e8306]
Page Load Metrics (1487 ± 157 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #17392 +/- ##
===========================================
+ Coverage 59.93% 59.94% +0.01%
===========================================
Files 936 936
Lines 36021 36022 +1
Branches 9269 9269
===========================================
+ Hits 21587 21590 +3
+ Misses 14434 14432 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
@darkwing should we add autoHide for |
Good shout @NidhiKJha ! Updated! |
d74e51e
to
48c3721
Compare
Builds ready [48c3721]
Page Load Metrics (1612 ± 545 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA test OK, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Explanation
When the autohide timer goes off, we should record the event so state updates and the ActionableMessage doesn't display again.
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.