Put hardware wallets behind an HARDWARE_WALLETS_MV3 flag

[segun]

Disable Hardware connect buttons if the flag is set.

Signed-off-by: Akintayo A. Olusegun [email protected]

update to metamask/eth-keyring-controller

Signed-off-by: Akintayo A. Olusegun [email protected]

revert to eth-keyring-controller v8

Signed-off-by: Akintayo A. Olusegun [email protected]

LAvamost after rebase

Signed-off-by: Akintayo A. Olusegun [email protected]

lock file.

Signed-off-by: Akintayo A. Olusegun [email protected]

Added toaster for removed NFTs (#17297)

• added notification for remove nfts

• reverted names for tabs

• updated default key

• updated snapshot

• updated remove nft toast to danger

Setup network controller mocks per-test (#17250)

The network controller unit test network mocks are now setup for each test. This makes modifying network behavior on a per-test basis easier, and makes it more clear which test relies upon which mocks.

Security provider check (OpenSea) (#16584)

chore: copy update for metamask fee on swaps (#17133)

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [90dee4d]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1427 ± 124 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	175	134	17	8
		domContentLoaded	1041	1939	1398	269	129
		load	1041	1939	1427	259	124
		domInteractive	1041	1939	1397	269	129

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 304 bytes
• ui: 345 bytes
• common: 0 bytes

[codecov-commenter]

Codecov Report

Merging #17354 (90dee4d) into develop (51518c4) will decrease coverage by 0.01%.
The diff coverage is 16.67%.

@@             Coverage Diff             @@
##           develop   #17354      +/-   ##
===========================================
- Coverage    60.05%   60.04%   -0.01%     
===========================================
  Files          936      936              
  Lines        36047    36057      +10     
  Branches      9261     9268       +7     
===========================================
+ Hits         21646    21648       +2     
- Misses       14401    14409       +8     

Impacted Files	Coverage Δ
...create-account/connect-hardware/select-hardware.js	0.00% <0.00%> (ø)
app/scripts/metamask-controller.js	60.54% <33.33%> (+0.05%)	⬆️
app/scripts/migrations/023.js	93.75% <0.00%> (-3.12%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[danjm]

Copying over my comment from the other PR:

setLedgerTransportPreference in the metamask-controller should not be called, or should return immediately, if canUseHardwareWallets() is false

[danjm]

one change needed

[danjm]

LGTM

[jpuri]

👍

[metamaskbot]

Builds ready [14e99fa]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1284 ± 116 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	197	118	22	11
		domContentLoaded	1000	1667	1260	233	112
		load	1020	1745	1284	241	116
		domInteractive	1000	1667	1260	233	112

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 354 bytes
• ui: 345 bytes
• common: 0 bytes