Setup network controller mocks per-test #17250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Gudahtt
force-pushed
the
network-controller-construct-per-test
branch
from
1c6d8a7 to
bd6cdd4
Compare
BelfordZ
reviewed
Jan 17, 2023
Gudahtt
force-pushed
the
setup-network-controller-mocks-per-test
branch
from
9d94bf7 to
ebd7537
Compare
Builds ready [ebd7537]
Page Load Metrics (1417 ± 87 ms)
Bundle size diffs
|
mcmire
reviewed
Jan 17, 2023
Base automatically changed from
network-controller-construct-per-test
to
develop
January 17, 2023 23:28
Gudahtt
force-pushed
the
setup-network-controller-mocks-per-test
branch
2 times, most recently
from
b9337a9 to
28787e1
Compare
Builds ready [28787e1]
Page Load Metrics (1213 ± 118 ms)
Bundle size diffs
|
The network controller unit test network mocks are now setup for each test. This makes modifying network behavior on a per-test basis easier, and makes it more clear which test relies upon which mocks.
Gudahtt
force-pushed
the
setup-network-controller-mocks-per-test
branch
from
7149856 to
a541040
Compare
…bout initial config in tests where switching occurs
Builds ready [055ec6a]
Page Load Metrics (1342 ± 102 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
mcmire
approved these changes
Jan 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network controller unit test network mocks are now setup for each test. This makes modifying network behavior on a per-test basis easier, and makes it more clear which test relies upon which mocks.
This relates to #16962
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.