Refactor: Construct the network controller within each test #17199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends upon #17126 |
Gudahtt
force-pushed
the
network-controller-construct-per-test
branch
from
449b30d to
1c6d8a7
Compare
Builds ready [1c6d8a7]
Page Load Metrics (1186 ± 38 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## replace-network-controller-test-internal-mocks #17199 +/- ##
===============================================================================
Coverage 59.55% 59.55%
===============================================================================
Files 936 936
Lines 35959 35959
Branches 9213 9213
===============================================================================
Hits 21414 21414
Misses 14545 14545 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
8 tasks
Base automatically changed from
replace-network-controller-test-internal-mocks
to
develop
January 17, 2023 18:09
The network controller is now constructed within each network controller unit test, rather than in the `beforeEach`. This allows us to customize the constructor options in each test, which some planned future tests will require. The controller is constructed with a helper function that also handles calling `destroy` after each test, even if the test failed. This helps to prevent tests from affecting each other.
Gudahtt
force-pushed
the
network-controller-construct-per-test
branch
from
1c6d8a7 to
bd6cdd4
Compare
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Builds ready [714402c]
Page Load Metrics (1515 ± 94 ms)
Bundle size diffs
|
mcmire
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network controller is now constructed within each network controller unit test, rather than in the
beforeEach. This allows us to customize the constructor options in each test, which some planned future tests will require.The controller is constructed with a helper function that also handles calling
destroyafter each test, even if the test failed. This helps to prevent tests from affecting each other.This relates to #16962
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.