icon audit, remove xxs icon size #17089

garrettbear · 2023-01-05T22:18:22Z

Explanation

Update Icon names, remove unused icons, add missing icons, and fix icons with stroke/line issues.

Fixes Icon audit updates #16786

Screenshots/Screencaps

Before

After

Manual Testing Steps

yarn test:unit:jest ui/components/component-library

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-01-05T22:18:36Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-01-05T22:45:16Z

Builds ready [fea715f]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1605 ± 189 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	1528	207	305	146
		domContentLoaded	1214	3073	1592	393	189
		load	1214	3073	1605	394	189
		domInteractive	1214	3073	1592	393	189

Bundle size diffs

background: 0 bytes
ui: -16 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2023-01-06T02:35:01Z

Builds ready [9a3a2f8]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1425 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	176	126	23	11
		domContentLoaded	1192	1729	1419	176	84
		load	1192	1729	1425	174	83
		domInteractive	1192	1729	1419	176	84

Bundle size diffs

background: 0 bytes
ui: -1711 bytes
common: 0 bytes

highlights:

storybook

georgewrmarshall

Hmm I did write the generate icons script to remove the icon- prefix and have it as a requirement for all icon files. I'm actually surprised it still works but now I see that it takes all svgs in the icons folder not the ones prefixed with icon-

garrettbear · 2023-01-10T21:35:51Z

Hmm I did write the generate icons script to remove the icon- prefix and have it as a requirement for all icon files. I'm actually surprised it still works but now I see that it takes all svgs in the icons folder not the ones prefixed with icon-

Oh you are right the generator does remove the icon- for the name, but I guess it was unclear to me if the raw file names were supposed to match the Figma file which is why I renamed them all. We can keep the functions for removing icon- in the generator in the event that someone does add a file starting with that name or I can remove it.

metamaskbot · 2023-01-10T22:23:07Z

Builds ready [6e39bad]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1280 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	139	111	13	6
		domContentLoaded	1117	1701	1269	188	90
		load	1117	1709	1280	191	92
		domInteractive	1117	1701	1269	188	90

Bundle size diffs

background: 0 bytes
ui: -1649 bytes
common: 0 bytes

highlights:

storybook

georgewrmarshall

I think we can also remove all the ids from the svgs files.

metamaskbot · 2023-01-11T02:20:42Z

Builds ready [1471f39]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1531 ± 135 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	179	131	25	12
		domContentLoaded	1162	2215	1516	266	128
		load	1162	2287	1531	282	135
		domInteractive	1162	2215	1515	266	128

Bundle size diffs

background: 0 bytes
ui: -1649 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2023-01-11T23:51:32Z

Builds ready [eb82787]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1193 ± 37 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	89	150	117	14	7
		domContentLoaded	1039	1311	1184	70	34
		load	1039	1311	1193	76	37
		domInteractive	1039	1311	1183	70	34

Bundle size diffs

background: 0 bytes
ui: -1649 bytes
common: 0 bytes

highlights:

storybook

georgewrmarshall

Everything looks great! Just one suggestion about the font awesome story

ui/components/component-library/icon/icon.stories.js

metamaskbot · 2023-01-19T22:22:48Z

Builds ready [321b212]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1295 ± 113 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	189	116	20	10
		domContentLoaded	974	1687	1274	236	113
		load	974	1687	1295	236	113
		domInteractive	974	1687	1274	236	113

Bundle size diffs

background: 0 bytes
ui: -1654 bytes
common: 0 bytes

highlights:

storybook

codecov-commenter · 2023-01-19T22:24:44Z

Codecov Report

Merging #17089 (321b212) into develop (83d74b6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #17089   +/-   ##
========================================
  Coverage    59.80%   59.80%           
========================================
  Files          937      937           
  Lines        36141    36141           
  Branches      9284     9284           
========================================
  Hits         21614    21614           
  Misses       14527    14527

Impacted Files	Coverage Δ
...-request-siwe/signature-request-siwe-icon/index.js	`0.00% <ø> (ø)`
...component-library/avatar-favicon/avatar-favicon.js	`100.00% <ø> (ø)`
...nents/component-library/button-base/button-base.js	`100.00% <ø> (ø)`
...omponents/component-library/icon/icon.constants.js	`100.00% <ø> (ø)`
ui/components/component-library/icon/icon.js	`100.00% <ø> (ø)`
ui/components/component-library/tag-url/tag-url.js	`100.00% <ø> (ø)`
...ent-library/text-field-search/text-field-search.js	`80.00% <ø> (ø)`
...ponents/component-library/text-field/text-field.js	`100.00% <ø> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

georgewrmarshall

LGTM!

metamaskbot · 2023-01-23T22:33:59Z

Builds ready [a2d9910]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1301 ± 102 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	100	173	125	19	9
		domContentLoaded	1030	1658	1261	206	99
		load	1030	1738	1301	212	102
		domInteractive	1030	1658	1261	206	99

Bundle size diffs

background: 0 bytes
ui: -1654 bytes
common: 0 bytes

icon audit, remove xxs icon size

fea715f

garrettbear added 2 commits January 5, 2023 18:07

update icon file names and snapshots

4e3c78c

Merge branch 'develop' into feat/16786/icon-audit

9a3a2f8

georgewrmarshall reviewed Jan 10, 2023

View reviewed changes

garrettbear requested review from georgewrmarshall and NidhiKJha January 10, 2023 21:42

Merge branch 'develop' into feat/16786/icon-audit

b4efaa4

garrettbear marked this pull request as ready for review January 10, 2023 21:42

garrettbear requested a review from a team as a code owner January 10, 2023 21:42

remove unused icon- code and fix icons with slash issue

6e39bad

garrettbear requested a review from kumavis as a code owner January 10, 2023 21:51

georgewrmarshall reviewed Jan 11, 2023

View reviewed changes

close icon fix

1471f39

garrettbear requested a review from georgewrmarshall January 11, 2023 16:41

remove icons id

77ba798

garrettbear force-pushed the feat/16786/icon-audit branch from 6be9cce to 77ba798 Compare January 11, 2023 16:59

garrettbear added 3 commits January 11, 2023 08:59

Merge branch 'develop' into feat/16786/icon-audit

dac5158

update snapshot

a6716ae

font awesome icon list

eb82787

georgewrmarshall reviewed Jan 12, 2023

View reviewed changes

ui/components/component-library/icon/icon.stories.js Outdated Show resolved Hide resolved

garrettbear added 2 commits January 13, 2023 09:33

remove font awesome

d5c68ee

Merge branch 'develop' into feat/16786/icon-audit

7f6d167

garrettbear requested a review from georgewrmarshall January 13, 2023 17:36

georgewrmarshall previously approved these changes Jan 13, 2023

View reviewed changes

garrettbear added 2 commits January 19, 2023 13:50

Merge branch 'develop' into feat/16786/icon-audit

6510660

fix linting issue

321b212

garrettbear dismissed georgewrmarshall’s stale review via 321b212 January 19, 2023 21:59

garrettbear requested a review from georgewrmarshall January 19, 2023 22:00

georgewrmarshall approved these changes Jan 23, 2023

View reviewed changes

Merge branch 'develop' into feat/16786/icon-audit

a2d9910

NidhiKJha approved these changes Jan 23, 2023

View reviewed changes

darkwing mentioned this pull request Jan 23, 2023

NFTs: Ensure proper icons are used in transaction feed #17362

Closed

garrettbear merged commit 0bf6aeb into develop Jan 24, 2023

garrettbear deleted the feat/16786/icon-audit branch January 24, 2023 17:39

github-actions bot locked and limited conversation to collaborators Jan 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

icon audit, remove xxs icon size #17089

icon audit, remove xxs icon size #17089

garrettbear commented Jan 5, 2023 •

edited

Loading

github-actions bot commented Jan 5, 2023

metamaskbot commented Jan 5, 2023

metamaskbot commented Jan 6, 2023

georgewrmarshall left a comment

garrettbear commented Jan 10, 2023

metamaskbot commented Jan 10, 2023

georgewrmarshall left a comment

metamaskbot commented Jan 11, 2023

metamaskbot commented Jan 11, 2023

georgewrmarshall left a comment

metamaskbot commented Jan 19, 2023

codecov-commenter commented Jan 19, 2023

georgewrmarshall left a comment

metamaskbot commented Jan 23, 2023

icon audit, remove xxs icon size #17089

icon audit, remove xxs icon size #17089

Conversation

garrettbear commented Jan 5, 2023 • edited Loading

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Jan 5, 2023

metamaskbot commented Jan 5, 2023

highlights:

metamaskbot commented Jan 6, 2023

highlights:

georgewrmarshall left a comment

Choose a reason for hiding this comment

garrettbear commented Jan 10, 2023

metamaskbot commented Jan 10, 2023

highlights:

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 11, 2023

highlights:

metamaskbot commented Jan 11, 2023

highlights:

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 19, 2023

highlights:

codecov-commenter commented Jan 19, 2023

Codecov Report

georgewrmarshall left a comment

Choose a reason for hiding this comment

metamaskbot commented Jan 23, 2023

garrettbear commented Jan 5, 2023 •

edited

Loading