Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Update genesis asset schema for interoperability #8151

Closed
Tracked by #7210
ishantiw opened this issue Feb 15, 2023 · 1 comment · Fixed by #8239, #8308 or #8317
Closed
Tracked by #7210

Update genesis asset schema for interoperability #8151

ishantiw opened this issue Feb 15, 2023 · 1 comment · Fixed by #8239, #8308 or #8317
Assignees
Labels
framework/module/interoperability Interoperability module
Milestone

Comments

@ishantiw
Copy link
Contributor

ishantiw commented Feb 15, 2023

Description

Update genesisInteroperabilityStoreSchema based on LIP PR so that genesis-assets are consistent with genesis-assets of other modules.

Acceptance Criteria

  • Should pass all the unit tests
@ishantiw ishantiw added the framework/module/interoperability Interoperability module label Feb 15, 2023
@Madhulearn Madhulearn added this to the Sprint 89 milestone Feb 24, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 89, Sprint 90 Feb 28, 2023
@Madhulearn Madhulearn modified the milestones: Sprint 90, Sprint 91 Mar 14, 2023
ishantiw added a commit that referenced this issue Mar 24, 2023
…ccounts and terminatedOutboxAccounts (#8238)

### What was the problem?

This PR resolves #8151 (ONLY mainchain)
Sidechain PR: #8256

### How was it solved?
Verification checks applied per
[LIP](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#mainchain)
Relevant PR: #8239

**Note:** 
- To reduce size of PR, this task is split into multiple PRs
- This PR only covers mainchain part

### How was it tested?

- Test cases added to `module.spec.ts`
- To check/verify schema at example path: 
    - cd lisk-sdk/examples/pos-mainchain
- ./bin/run genesis-block:create --output=config/default
--assets-file=./config/default/genesis_assets.json
- To run example app
    -  ./bin/run start --api-ipc --api-http --port 9001
- if it fails with `Error: Genesis block does not match.`, run `rm -rf
~/.lisk/pos-mainchain` (**Note:**, it's not `rm -rf
~/.lisk/dpos-mainchain`)
ishantiw added a commit that referenced this issue Mar 24, 2023
…unts and terminatedOutboxAccounts (#8239)

### What was the problem?
This PR resolves #8151 (ONLY mainchain)

Relevant PR: #8238

### How was it solved?
Verification checks applied per
[LIP](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#mainchain)


### How was it tested?

Test cases added to `module.spec.ts`
@Madhulearn Madhulearn modified the milestones: Sprint 91, Sprint 92 Mar 27, 2023
@ishantiw ishantiw reopened this Apr 5, 2023
@ishantiw
Copy link
Contributor Author

ishantiw commented Apr 5, 2023

Reopening the issue as still #8317 needs to be merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.