Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Align Interoperability asset generation with the current schema #274

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Align Interoperability asset generation with the current schema #274

merged 3 commits into from
Feb 24, 2023

Conversation

sergeyshemyakov
Copy link
Contributor

@sergeyshemyakov sergeyshemyakov commented Feb 21, 2023 •
edited
Loading

  1. Closes Update Interoperability genesis asset processing in LIP 0063 #269.
  2. Fixes a small bug in Interoperability genesis own chain store initialization.
  3. Minor correction in a variable name (stake to vote).

@sergeyshemyakov sergeyshemyakov self-assigned this Feb 21, 2023
@sameersubudhi sameersubudhi mentioned this pull request Feb 22, 2023
Closed
sameersubudhi
sameersubudhi approved these changes Feb 22, 2023
View reviewed changes
Copy link
Contributor

@sameersubudhi sameersubudhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
And, created issue (LiskArchive/lisk-migrator#84) to update the migrator implementation accordingly.

@ishantiw ishantiw mentioned this pull request Feb 23, 2023
Closed
janhack
janhack approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@janhack janhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial approval

@janhack janhack merged commit 54bfad2 into main Feb 24, 2023
@janhack janhack deleted the fix-interop-genesis-assets branch February 24, 2023 12:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ishantiw ishantiw ishantiw approved these changes

@ricott1 ricott1 ricott1 approved these changes

@sameersubudhi sameersubudhi sameersubudhi approved these changes

@janhack janhack janhack approved these changes

@AndreasKendziorra AndreasKendziorra AndreasKendziorra approved these changes

Assignees

@sergeyshemyakov sergeyshemyakov

Labels
implementation change lip modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Interoperability genesis asset processing in LIP 0063
6 participants
@sergeyshemyakov @ishantiw @ricott1 @sameersubudhi @janhack @AndreasKendziorra