-
Notifications
You must be signed in to change notification settings - Fork 13
Change interoperability genesis asset schema #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left several comments. My main ones are about precisely defining 'empty' substores.
Currently, we allow for direct channels in the genesis block, but maybe we shouldn't as this is not possible to do with the current protocol. If we don't, the protocol would become drastically simpler. |
… order of chainInfos entries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created related issue on SDK LiskArchive/lisk-sdk#8151
Co-authored-by: AndreasKendziorra <[email protected]>
Co-authored-by: AndreasKendziorra <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I left some minor comments/recommendations, but did not find something critical. It's ok to me to be merged with the current version.
@@ -236,7 +236,7 @@ In this section, we specify the substores that are part of the Interoperability | |||
| `MIN_CHAIN_NAME_LENGTH` | uint32 | 1 | The minimum length of a string specifying the name of a chain. | | |||
| `MAX_CHAIN_NAME_LENGTH` | uint32 | 32 | The maximum length of a string specifying the name of a chain. | | |||
|
|||
We further use the utility function `getMainchainID()` defined in [LIP 0037][lip-0037#getMainchainID] to obtain the chain ID of the mainchain. | |||
We further use the utility function `getMainchainID` defined in [LIP 0037][lip-0037#getMainchainID] to obtain the chain ID of the mainchain. | |||
|
|||
#### Empty Cross-chain Message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just checked this by accident. I think description of empty ccm in the table should be improved since it does not fully follow the ccmSchema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial approval
Closes #248.