This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Remove mainchain check if sidechain is registered in genesis #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #8235 +/- ##
===============================================
- Coverage 83.06% 83.05% -0.01%
===============================================
Files 588 588
Lines 21749 21741 -8
Branches 3172 3168 -4
===============================================
- Hits 18065 18057 -8
Misses 3684 3684
|
|
I think initGenesisBlock part is going to get updated in #8151 so maybe we should update it afterwards? |
|
This PR is on-hold until @sitetester's #8238 #8239 #8256 are merged. |
|
Closing this PR, which will be re-opened in the future |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8150
How was it solved?
Remove mainchain check from init stage
How was it tested?
Test cases passed