This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
Update genesis asset schema interoperability sidechain #8256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAccounts & terminatedOutboxAccounts)
…eAccounts & terminatedOutboxAccounts)
…OutboxAccounts' of https://github.com/LiskHQ/lisk-sdk into 8151-update-with-terminatedStateAccounts-and-terminatedOutboxAccounts
…eAccounts & terminatedOutboxAccounts) # Conflicts: # framework/src/modules/interoperability/mainchain/module.ts
- Include ALL changes from mainchain - Apply sidechain verification (this also includes common checks with mainchain)
sitetester
changed the base branch from
8151-update-genesis-asset-schema-interoperability
to
8151-update-with-terminatedStateAccounts-and-terminatedOutboxAccounts
sitetester
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8151-update-with-terminatedStateAccounts-and-terminatedOutboxAccounts #8256 +/- ##
=========================================================================================================
+ Coverage 83.10% 83.14% +0.04%
=========================================================================================================
Files 588 588
Lines 21722 21804 +82
Branches 3164 3192 +28
=========================================================================================================
+ Hits 18051 18129 +78
- Misses 3671 3675 +4
|
…tedOutboxAccounts' of github.com:LiskHQ/lisk-sdk into 8151-update-with-terminatedStateAccounts-and-terminatedOutboxAccounts
…OutboxAccounts' of github.com:LiskHQ/lisk-sdk into 8151-update-genesis-asset-schema-interoperability-sidechain
ishantiw
added a commit
that referenced
this pull request
Mar 24, 2023
…ccounts and terminatedOutboxAccounts (#8238) ### What was the problem? This PR resolves #8151 (ONLY mainchain) Sidechain PR: #8256 ### How was it solved? Verification checks applied per [LIP](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#mainchain) Relevant PR: #8239 **Note:** - To reduce size of PR, this task is split into multiple PRs - This PR only covers mainchain part ### How was it tested? - Test cases added to `module.spec.ts` - To check/verify schema at example path: - cd lisk-sdk/examples/pos-mainchain - ./bin/run genesis-block:create --output=config/default --assets-file=./config/default/genesis_assets.json - To run example app - ./bin/run start --api-ipc --api-http --port 9001 - if it fails with `Error: Genesis block does not match.`, run `rm -rf ~/.lisk/pos-mainchain` (**Note:**, it's not `rm -rf ~/.lisk/dpos-mainchain`)
ishantiw
changed the base branch from
8151-update-with-terminatedStateAccounts-and-terminatedOutboxAccounts
to
development
sitetester
changed the base branch from
development
to
8151-update-genesis-asset-schema-interoperability
ishantiw
deleted the
8151-update-genesis-asset-schema-interoperability-sidechain
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
This PR resolves #8151
Mainchain PR: #8239
How was it solved?
This PR includes:
mainchain.spec.tsmoved tointeropFixtures.tsbase_interoperability_module.spec.tsHow was it tested?
module.spec.ts added for
sidechain