-
Notifications
You must be signed in to change notification settings - Fork 454
Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238
Conversation
…inatedStateAccounts & _verifyTerminatedOutboxAccounts)
…able to mainchain
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 8151-update-genesis-asset-schema-interoperability #8238 +/- ##
=====================================================================================
- Coverage 83.06% 83.06% -0.01%
=====================================================================================
Files 588 588
Lines 21747 21679 -68
Branches 3170 3150 -20
=====================================================================================
- Hits 18065 18008 -57
+ Misses 3682 3671 -11
|
…tion timeout. Please check if IPC server is running.` error
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
framework/test/unit/modules/interoperability/mainchain/module.spec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, couple of minor comments but approving
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just caught few inconsistencies, looks good otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Franco! Fine, for me, just left one minor comment for you.
@@ -152,20 +107,19 @@ | |||
"type": "array", | |||
"items": { | |||
"dataType": "bytes", | |||
"minLength": 32, | |||
"maxLength": 32 | |||
"length": 32 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well, we need to use "minLength", "maxLength"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
…ithub.com:LiskHQ/lisk-sdk into 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts
…unts and terminatedOutboxAccounts (#8239) ### What was the problem? This PR resolves #8151 (ONLY mainchain) Relevant PR: #8238 ### How was it solved? Verification checks applied per [LIP](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#mainchain) ### How was it tested? Test cases added to `module.spec.ts`
What was the problem?
This PR resolves #8151 (ONLY mainchain)
Sidechain PR: #8256
How was it solved?
Verification checks applied per LIP
Relevant PR: #8239
Note:
How was it tested?
module.spec.ts
Error: Genesis block does not match.
, runrm -rf ~/.lisk/pos-mainchain
(Note:, it's notrm -rf ~/.lisk/dpos-mainchain
)