Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238

sitetester · 2023-03-07T11:27:02Z

What was the problem?

This PR resolves #8151 (ONLY mainchain)
Sidechain PR: #8256

How was it solved?

Verification checks applied per LIP
Relevant PR: #8239

Note:

To reduce size of PR, this task is split into multiple PRs
This PR only covers mainchain part

How was it tested?

Test cases added to module.spec.ts
To check/verify schema at example path:
- cd lisk-sdk/examples/pos-mainchain
- ./bin/run genesis-block:create --output=config/default --assets-file=./config/default/genesis_assets.json
To run example app
- ./bin/run start --api-ipc --api-http --port 9001
- if it fails with Error: Genesis block does not match., run rm -rf ~/.lisk/pos-mainchain (Note:, it's not rm -rf ~/.lisk/dpos-mainchain)

…ec.ts

…inatedStateAccounts & _verifyTerminatedOutboxAccounts)

…able to mainchain

codecov · 2023-03-07T11:49:17Z

Codecov Report

Merging #8238 (85c26f5) into 8151-update-genesis-asset-schema-interoperability (de0b926) will decrease coverage by 0.01%.
The diff coverage is 97.93%.

❗ Current head 85c26f5 differs from pull request most recent head 958e791. Consider uploading reports for the commit 958e791 to get more accurate results

Additional details and impacted files

@@                                  Coverage Diff                                  @@
##           8151-update-genesis-asset-schema-interoperability    #8238      +/-   ##
=====================================================================================
- Coverage                                              83.06%   83.06%   -0.01%     
=====================================================================================
  Files                                                    588      588              
  Lines                                                  21747    21679      -68     
  Branches                                                3170     3150      -20     
=====================================================================================
- Hits                                                   18065    18008      -57     
+ Misses                                                  3682     3671      -11

Impacted Files	Coverage Δ
...s/interoperability/base_interoperability_module.ts	`96.55% <75.00%> (+4.24%)`	⬆️
...k/src/modules/interoperability/mainchain/module.ts	`95.38% <98.78%> (+5.58%)`	⬆️
framework/src/modules/interoperability/schemas.ts	`100.00% <100.00%> (ø)`
...c/modules/interoperability/stores/chain_account.ts	`100.00% <100.00%> (ø)`
framework/src/modules/interoperability/utils.ts	`91.71% <100.00%> (+0.04%)`	⬆️
framework/src/testing/create_contexts.ts	`93.81% <100.00%> (-0.37%)`	⬇️

…tion timeout. Please check if IPC server is running.` error

examples/pos-mainchain/config/default/genesis_assets.json

framework/src/modules/interoperability/schemas.ts

framework/src/modules/interoperability/mainchain/module.ts

framework/src/modules/interoperability/schemas.ts

framework/test/unit/modules/interoperability/mainchain/module.spec.ts

framework/src/modules/interoperability/mainchain/module.ts

ishantiw

Overall looks good, couple of minor comments but approving

examples/pos-mainchain/config/default/genesis_assets.json

framework/test/unit/modules/interoperability/mainchain/module.spec.ts

gkoumout

Just caught few inconsistencies, looks good otherwise.

examples/pos-mainchain/config/default/genesis_assets.json

framework/src/modules/interoperability/mainchain/module.ts

framework/src/modules/interoperability/schemas.ts

framework/src/modules/interoperability/mainchain/module.ts

gkoumout

Good job Franco! Fine, for me, just left one minor comment for you.

examples/pos-mainchain/config/default/genesis_assets.json

framework/src/modules/interoperability/schemas.ts

ishantiw · 2023-03-21T16:29:13Z

examples/pos-mainchain/config/default/genesis_assets.json

@@ -152,20 +107,19 @@
 													"type": "array",
 													"items": {
 														"dataType": "bytes",
-														"minLength": 32,
-														"maxLength": 32
+														"length": 32


here as well, we need to use "minLength", "maxLength"

…ithub.com:LiskHQ/lisk-sdk into 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts

…unts and terminatedOutboxAccounts (#8239) ### What was the problem? This PR resolves #8151 (ONLY mainchain) Relevant PR: #8238 ### How was it solved? Verification checks applied per [LIP](https://github.com/LiskHQ/lips/blob/main/proposals/lip-0045.md#mainchain) ### How was it tested? Test cases added to `module.spec.ts`

sitetester added 9 commits March 7, 2023 11:54

Add mainchain related checks & test cases

9c9ddf1

Add LIP reference to functions

86a22fe

Remove this file, since relevant tests are already added in module.sp…

5819dd1

…ec.ts

Add LIP reference to schema

487c83a

Remove unused signature param

4735f20

Update error message & relevant test

6beeccc

Remove un-relevant case

7bbbcd8

Update genesis asset schema for interoperability (without _verifyTerm…

961630f

…inatedStateAccounts & _verifyTerminatedOutboxAccounts)

Remove describe('On the mainchain',, since this file is only applic…

5a324a5

…able to mainchain

sitetester changed the title ~~Update genesis asset schema interoperability without terminatedStateAccounts and terminatedOutboxAccounts~~ Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts Mar 7, 2023

sitetester added 2 commits March 7, 2023 18:45

Update schema at example path

6260722

Update genesis block. This is needed to fix `IPC Socket client connec…

eeb7faf

…tion timeout. Please check if IPC server is running.` error

sitetester marked this pull request as ready for review March 7, 2023 18:28

sitetester requested review from ishantiw and shuse2 March 7, 2023 18:28

Move decode & validate related part to concrete class

04a4e68

sitetester mentioned this pull request Mar 8, 2023

Update genesis asset schema interoperability WITH terminatedStateAccounts and terminatedOutboxAccounts #8239

Merged

ishantiw assigned sitetester Mar 9, 2023

shuse2 requested review from gkoumout and removed request for shuse2 March 13, 2023 09:25

gkoumout suggested changes Mar 14, 2023

View reviewed changes

Phanco mentioned this pull request Mar 15, 2023

Remove mainchain check if sidechain is registered in genesis #8235

Closed

ishantiw suggested changes Mar 15, 2023

View reviewed changes

Updated genesis_assets.json and captions

3b873d5

Phanco requested review from ishantiw and gkoumout March 16, 2023 10:10

ishantiw approved these changes Mar 17, 2023

View reviewed changes

examples/pos-mainchain/config/default/genesis_assets.json Outdated Show resolved Hide resolved

framework/test/unit/modules/interoperability/mainchain/module.spec.ts Show resolved Hide resolved

gkoumout suggested changes Mar 17, 2023

View reviewed changes

Updated genesis_assets and modules.ts according to PR comments

85c26f5

Phanco requested a review from gkoumout March 21, 2023 13:58

gkoumout approved these changes Mar 21, 2023

View reviewed changes

examples/pos-mainchain/config/default/genesis_assets.json Outdated Show resolved Hide resolved

framework/src/modules/interoperability/schemas.ts Show resolved Hide resolved

ishantiw reviewed Mar 21, 2023

View reviewed changes

Phanco added 2 commits March 21, 2023 17:36

Replace length with minLength and maxLength

2509bf7

Merge branch '8151-update-genesis-asset-schema-interoperability' of g…

958e791

…ithub.com:LiskHQ/lisk-sdk into 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts

ishantiw merged commit e9eb5c3 into 8151-update-genesis-asset-schema-interoperability Mar 24, 2023

ishantiw deleted the 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts branch March 24, 2023 09:41

sitetester restored the 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts branch March 25, 2023 11:57

sitetester deleted the 8151-update-without-terminatedStateAccounts-and-terminatedOutboxAccounts branch March 27, 2023 06:59

sitetester mentioned this pull request Mar 27, 2023

Update genesis asset schema interoperability mainchain #8308

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238

Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238

sitetester commented Mar 7, 2023 •

edited

Loading

codecov bot commented Mar 7, 2023 •

edited

Loading

ishantiw left a comment

gkoumout left a comment

gkoumout left a comment

ishantiw Mar 21, 2023

Phanco Mar 21, 2023

Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238

Update genesis asset schema interoperability WITHOUT terminatedStateAccounts and terminatedOutboxAccounts #8238

Conversation

sitetester commented Mar 7, 2023 • edited Loading

What was the problem?

How was it solved?

How was it tested?

codecov bot commented Mar 7, 2023 • edited Loading

Codecov Report

ishantiw left a comment

Choose a reason for hiding this comment

gkoumout left a comment

Choose a reason for hiding this comment

gkoumout left a comment

Choose a reason for hiding this comment

ishantiw Mar 21, 2023

Choose a reason for hiding this comment

Phanco Mar 21, 2023

Choose a reason for hiding this comment

sitetester commented Mar 7, 2023 •

edited

Loading

codecov bot commented Mar 7, 2023 •

edited

Loading