Version Packages #536
Merged
Version Packages #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
somewhatabstract
force-pushed
the
changeset-release/main
branch
from
c5bc5e0 to
a8cc119
Compare
|
Size Change: 0 B Total Size: 4.32 kB ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #536 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 839 839
Branches 233 233
=========================================
Hits 839 839 Continue to review full report at Codecov.
|
somewhatabstract
force-pushed
the
changeset-release/main
branch
6 times, most recently
from
7a4b447 to
c5734ce
Compare
jeresig
approved these changes
Feb 21, 2023
kevinbarabash
added a commit
that referenced
this pull request
Feb 21, 2023
## Summary: When reviewing the changes in #536, I noticed that some packages were being bumped a major version even though none of the changeset .md files specified such changes. It appears this is happening due changeset treating peer deps differently from regular deps. This PR fixes the issue by make wonder-stuff-core a regular dependency of wonder-stuff-server. Issue: None ## Test plan: - land this PR and see #536 update appropriately Author: kevinbarabash Reviewers: jeresig, #frontend-infra, #typescript, somewhatabstract Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Analyze (javascript), ✅ gerald, ⏭ dependabot Pull Request URL: #544
somewhatabstract
force-pushed
the
changeset-release/main
branch
from
c5734ce to
a770367
Compare
kevinbarabash
added a commit
that referenced
this pull request
Feb 21, 2023
## Summary: I updated wonder-stuff-server's deps in #544, but missing that wonder-stuff-testing and wonder-stuff-server-google are affected by the same issue. This PR fixes them as well. Issue: None ## Test plan: - Land and wait for #536, see that wonder-stuff-server-google and wonder-stuff-testing are bumped by a minor version Author: kevinbarabash Reviewers: jeresig Required Reviewers: Approved By: jeresig Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ⏭ dependabot Pull Request URL: #545
somewhatabstract
force-pushed
the
changeset-release/main
branch
from
a770367 to
857e24a
Compare
somewhatabstract
force-pushed
the
changeset-release/main
branch
from
857e24a to
2d8d059
Compare
kevinbarabash
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
@khanacademy/[email protected]
Minor Changes
Patch Changes
[email protected]
Minor Changes
Patch Changes