Skip to content

Commit

Permalink
Convert more peer deps into real deps (#545)
Browse files Browse the repository at this point in the history
## Summary:
I updated wonder-stuff-server's deps in #544, but missing that wonder-stuff-testing and wonder-stuff-server-google are affected by the same issue.  This PR fixes them as well.

Issue: None

## Test plan:
- Land and wait for #536, see that wonder-stuff-server-google and wonder-stuff-testing are bumped by a minor version

Author: kevinbarabash

Reviewers: jeresig

Required Reviewers:

Approved By: jeresig

Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ gerald, ✅ Analyze (javascript), ⏭  dependabot

Pull Request URL: #545
  • Loading branch information
kevinbarabash authored Feb 21, 2023
1 parent dd0682c commit c38fc71
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .changeset/dull-fishes-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@khanacademy/wonder-stuff-server-google": patch
"@khanacademy/wonder-stuff-testing": patch
---

Convert wonder-stuff-\* peer dependencies to be real dependencies.
6 changes: 4 additions & 2 deletions packages/wonder-stuff-server-google/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,10 @@
"scripts": {
"test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'"
},
"dependencies": {
"@khanacademy/wonder-stuff-core": "^1.0.2",
"@khanacademy/wonder-stuff-server": "^2.0.2"
},
"devDependencies": {
"ws-dev-build-settings": "^0.0.5"
},
Expand All @@ -24,8 +28,6 @@
"@google-cloud/logging-winston": "^4.1.1",
"@google-cloud/profiler": "^4.1.7",
"@google-cloud/trace-agent": "^5.1.6",
"@khanacademy/wonder-stuff-core": "^1.0.2",
"@khanacademy/wonder-stuff-server": "^2.0.2",
"express": "^4.17.2",
"express-winston": "^4.2.0",
"winston": "^3.4.0"
Expand Down
6 changes: 3 additions & 3 deletions packages/wonder-stuff-testing/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@
"scripts": {
"test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'"
},
"dependencies": {
"@khanacademy/wonder-stuff-core": "^1.0.2"
},
"devDependencies": {
"ws-dev-build-settings": "^0.0.5"
},
"peerDependencies": {
"@khanacademy/wonder-stuff-core": "^1.0.2"
},
"browser": {
"dist/es/index.js": "./dist/es/index.browser.js",
"dist/index.js": "./dist/index.browser.js"
Expand Down

0 comments on commit c38fc71

Please sign in to comment.