Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert more peer deps into real deps #545

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

kevinbarabash
Copy link
Contributor

Summary:

I updated wonder-stuff-server's deps in #544, but missing that wonder-stuff-testing and wonder-stuff-server-google are affected by the same issue. This PR fixes them as well.

Issue: None

Test plan:

  • Land and wait for Version Packages #536, see that wonder-stuff-server-google and wonder-stuff-testing are bumped by a minor version

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2023

🦋 Changeset detected

Latest commit: 7760676

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@khanacademy/wonder-stuff-server-google Patch
@khanacademy/wonder-stuff-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kevinbarabash kevinbarabash self-assigned this Feb 21, 2023
@khan-actions-bot khan-actions-bot requested a review from a team February 21, 2023 19:59
@khan-actions-bot
Copy link
Contributor

khan-actions-bot commented Feb 21, 2023

Gerald

Required Reviewers
  • @Khan/frontend-infra for changes to .changeset/dull-fishes-relate.md, packages/wonder-stuff-server-google/package.json, packages/wonder-stuff-testing/package.json

Don't want to be involved in this pull request? Comment #removeme and we won't notify you of further changes.

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Merging #545 (7760676) into main (dd0682c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #545   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines          839       837    -2     
  Branches       233       224    -9     
=========================================
- Hits           839       837    -2     
Impacted Files Coverage Δ
packages/wonder-stuff-core/src/kind-error.ts 100.00% <0.00%> (ø)
...ges/wonder-stuff-server-google/src/start-server.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd0682c...7760676. Read the comment docs.

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 4.32 kB

ℹ️ View Unchanged
Filename Size
packages/wonder-stuff-core/dist/es/index.browser.js 1.68 kB
packages/wonder-stuff-sentry/dist/es/index.browser.js 1.66 kB
packages/wonder-stuff-testing/dist/es/index.browser.js 976 B

compressed-size-action

@kevinbarabash kevinbarabash merged commit c38fc71 into main Feb 21, 2023
@kevinbarabash kevinbarabash deleted the tweak-deps-a-bit-moar branch February 21, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants