Skip to content

Commit

Permalink
Make core a real dep of server (#544)
Browse files Browse the repository at this point in the history
## Summary:
When reviewing the changes in #536, I noticed that some packages were being bumped a major version even though none of the changeset .md files specified such changes.  It appears this is happening due changeset treating peer deps differently from regular deps.  This PR fixes the issue by make wonder-stuff-core a regular dependency of wonder-stuff-server.

Issue: None

## Test plan:
- land this PR and see #536 update appropriately

Author: kevinbarabash

Reviewers: jeresig, #frontend-infra, #typescript, somewhatabstract

Required Reviewers:

Approved By: jeresig

Checks: ✅ codecov/project, ✅ Test (macos-latest, 16.x), ✅ CodeQL, ✅ Lint, typecheck, and coverage check (ubuntu-latest, 16.x), ✅ Prime node_modules cache for primary configuration (ubuntu-latest, 16.x), ✅ Analyze (javascript), ✅ gerald, ⏭  dependabot

Pull Request URL: #544
  • Loading branch information
kevinbarabash authored Feb 21, 2023
1 parent 6eafb30 commit dd0682c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/beige-otters-exist.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@khanacademy/wonder-stuff-server": patch
---

Make wonder-stuff-core a real dependency instead of a peer dependency
4 changes: 3 additions & 1 deletion packages/wonder-stuff-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@
"scripts": {
"test": "bash -c 'yarn --silent --cwd \"../..\" test ${@:0} $($([[ ${@: -1} = -* ]] || [[ ${@: -1} = bash ]]) && echo $PWD)'"
},
"dependencies": {
"@khanacademy/wonder-stuff-core": "^1.0.2"
},
"devDependencies": {
"ws-dev-build-settings": "^0.0.5"
},
"author": "",
"license": "MIT",
"peerDependencies": {
"@khanacademy/wonder-stuff-core": "^1.0.2",
"express": "^4.17.2",
"express-winston": "^4.2.0",
"winston": "^3.4.0"
Expand Down

0 comments on commit dd0682c

Please sign in to comment.